New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return value after executing command request #284

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
3 participants
@danixeee
Contributor

danixeee commented Dec 5, 2017

Hello,
We have discussed about this issue here:
Microsoft/language-server-protocol#329

With this change, I am able to fetch values returned from server.

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Dec 5, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Dec 5, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dbaeumer

This comment has been minimized.

Show comment
Hide comment
@dbaeumer

dbaeumer Dec 5, 2017

Member

@danixeee this is a very good catch. Thanks for providing the PR.

Member

dbaeumer commented Dec 5, 2017

@danixeee this is a very good catch. Thanks for providing the PR.

@dbaeumer dbaeumer merged commit 6e1b4a0 into Microsoft:master Dec 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment