Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration parameters for workspace/didChangeWatchedFiles #320

Merged
merged 1 commit into from Apr 5, 2018

Conversation

@rcjsuen
Copy link
Contributor

commented Mar 16, 2018

It's currently not possible to register for workspace/didChangeWatchedFiles notifications because it has void set as a parameter. We should be using DidChangeWatchedFilesRegistrationOptions instead so that servers can define the interested files when sending its client/registerCapability request to the client.

Fix registration parameters for workspace/didChangeWatchedFiles
As workspace/didChangeWatchedFiles notifications must be registered
with some parameters, the signature must be fixed to match this
instead of incorrectly stating it as void.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@dbaeumer

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Thanks for the PR

@dbaeumer dbaeumer merged commit 042a822 into microsoft:master Apr 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@rcjsuen rcjsuen deleted the rcjsuen:dcwf-registration branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.