Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `undefined` to TextDocuments#get(uri: string) #339

Merged
merged 1 commit into from Apr 16, 2018

Conversation

@nikeee
Copy link
Contributor

commented Apr 13, 2018

As the documentation of TextDocuments#get(uri: string) funtion states:

Returns the document for the given URI. Returns undefined if the document is not mananged by this instance.

The return type does not reflect that it can return undefined. This commit adds that.

This might be a breaking change for existing code bases (which use strictNullChecks), so feel free to reject this PR.

Add `undefined` to TextDocuments#get(uri: string)
As the documentation of this funtion states:
> * Returns the document for the given URI. Returns undefined if
> * the document is not mananged by this instance.

The return type does not reflect that it can return undefined. This commit adds that.

@dbaeumer dbaeumer merged commit d9023cf into microsoft:master Apr 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@nikeee nikeee deleted the nikeee:textdocuments-get-undefined branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.