Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeActionOptions with providedCodeActionKinds #385

Merged
merged 1 commit into from Aug 21, 2018

Conversation

@Gama11
Copy link
Contributor

commented Jul 28, 2018

See here for the motivation: microsoft/language-server-protocol#389 (comment)

Corresponding language-server-protocol PR: microsoft/language-server-protocol#534

@Gama11 Gama11 referenced this pull request Aug 8, 2018

Closed

Organize imports support #388

@dbaeumer dbaeumer merged commit da8655d into microsoft:master Aug 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@Gama11 Gama11 deleted the Gama11:codeActionOptions branch Aug 21, 2018

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

@Gama11 you forgot the dynamic registration and that a feature needs to keep the state per registration and can't almost never have a single global state. I will do the changes. You might want to look at them for the next PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.