New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository.directory field to package.json #439

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@felixfbecker
Copy link
Contributor

felixfbecker commented Dec 12, 2018

This adds a directory field to the repository objects in package.json. This is a new field for monorepos specced in this npm RFC: https://github.com/npm/rfcs/blob/d39184cdedc000aa8e60b4d63878b834aa5f0ff0/accepted/0000-monorepo-subdirectory-declaration.md

It enables cross-repository go-to-definition on Sourcegraph, as Sourcegraph can resolve packages to a specific directory in the angular monorepo.
Clients that don't know this field simply ignore it (as with any other arbitrary field in package.json).

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Dec 13, 2018

@felixfbecker thanks. Wasn't aware of this.

@dbaeumer dbaeumer merged commit f9cfe06 into Microsoft:master Dec 13, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment