New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support loading scoped modules at runtime #10

Merged
merged 2 commits into from Mar 2, 2018

Conversation

Projects
None yet
3 participants
@ggilmore
Copy link
Contributor

ggilmore commented Nov 22, 2017

This adds functionality to support loading a scoped node package in a non-build context (e.g. using the yarn watch command, etc.).

Two questions:

  1. I don't know why the /** @class */ entries were added. I built the project using npm run watch-all. Do you know if that was the right command to use, or do I need to configure something else?

  2. Do you feel like this functionality needs testing. If so, could you point me in the direction of where/how to add it? I found the documentation regarding the testing structure to not be super helpful.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 22, 2017

CLA assistant check
All CLA requirements met.

@alexandrudima alexandrudima merged commit 895f32e into Microsoft:master Mar 2, 2018

1 check passed

license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment