New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates should be ISO formatted #570

Closed
kristofferostlund opened this Issue Dec 29, 2016 · 4 comments

Comments

Projects
3 participants
@kristofferostlund

kristofferostlund commented Dec 29, 2016

It would be great if the date formatting would follow an ISO standard (namely ISO 8601) instead of the US style way of writing dates (2016-12-29T08:58:36.226Z over 12/29/2016 08:58:36) as this would reduce possible confusion with dates such as 01/05/2016 which at a glance may look like May 1, 2016 instead of 5 January, 2016 (See here).

Another solution would be to make this configurable in the config file.


  • MSSQL Extension Version: 0.2.0
  • VSCode Version: 1.8.1
  • OS Version: OS X El Capitan (10.11.6)

Steps to Reproduce:

  1. Select a field with a type of date SELECT GETUTCDATE() AS [now]

screen shot 2016-12-29 at 09 55 37

@benrr101

This comment has been minimized.

Contributor

benrr101 commented Dec 29, 2016

Thanks for reporting this bit of feedback! A couple weeks back, I made a change to support displaying milliseconds in DATETIME2 fields. The additional goal of this was to make sure that any DATE, DATETIME, or DATETIME2 fields appeared the same way that they did in SSMS. Those changes were made but needed to be backed out due to a regression in displaying DATE fields. The more robust changes have been made and checked in (Microsoft/sqltoolsservice#196) but just missed the cut for the latest release.

This change should also address your request. SSMS formats date columns as almost the ISO format you listed. It uses 2016-12-29 08:58:36.226. I confirmed that this is the format that SSMS uses even in locales that use , instead of . for decimals. Can you confirm that this is a satisfactory solution?

@benrr101 benrr101 self-assigned this Dec 29, 2016

@benrr101 benrr101 added this to the MSSQL Preview Release 3 milestone Dec 29, 2016

@kristofferostlund

This comment has been minimized.

kristofferostlund commented Dec 30, 2016

That absolutely sounds like a good enough solution, thank you! Is there a time frame for when this will be merged and released?

@kevcunnane

This comment has been minimized.

Member

kevcunnane commented Jan 3, 2017

@kristofferostlund we will have it available in a nightly build this week which would let you test. We haven't locked down an exact timeframe for our next marketplace update, but will be adding the timelines to the Projects page as we get this planned out.

@benrr101

This comment has been minimized.

Contributor

benrr101 commented Jan 4, 2017

Since this fix is checked into our dev build, has been released in our latest few nightly builds, and is in the pipeline for next release, I'll close this issue up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment