New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sync fs.mkdir #17

Merged
merged 1 commit into from Mar 12, 2018

Conversation

Projects
None yet
2 participants
@BridgeAR
Copy link
Contributor

BridgeAR commented Feb 25, 2018

This ensures that errors are properly handled.

This is also going to cause issues with the upcoming Node.js 10.x. See nodejs/node#18668.

Use sync fs.mkdir
This ensures that errors are properly handled.
@BridgeAR

This comment has been minimized.

Copy link
Contributor

BridgeAR commented Mar 11, 2018

Ping @dbaeumer

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Mar 12, 2018

Makes sense.

@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Mar 12, 2018

Thanks for the PR.

@dbaeumer dbaeumer merged commit 84f9404 into Microsoft:master Mar 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment