New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to all telemetry events, and properly trigger start-up telemetry #183

Merged
merged 6 commits into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@digeff
Copy link
Contributor

digeff commented Mar 21, 2018

We report the node version and Versions.DebugAdapter as a common telemetry property
We also trigger ChromeDebugSession.FinishedStartingUpEventName to properly mark the end of startup and trigger the end of the report-start-up-timings telemetry event

return super.configurationDone();
await super.configurationDone();

this.events.emit(ChromeDebugSession.FinishedStartingUpEventName);

This comment has been minimized.

@roblourens

roblourens Mar 22, 2018

Member

Does this have to go after the super call? Would rather leave the super call as the last line unless there's a reason for it.

This comment has been minimized.

@digeff

digeff Mar 22, 2018

Contributor

Changed

if (!this.chrome) {
// It's possible to get this request after we've detached, see #21973
return super.configurationDone();
await super.configurationDone();
return;

This comment has been minimized.

@roblourens

roblourens Mar 22, 2018

Member

This is equivalent to return super.configurationDone(), you could leave it that way for simplicity

This comment has been minimized.

@digeff

digeff Mar 22, 2018

Contributor

Changed

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Mar 22, 2018

Lots of CI failures?

@digeff digeff force-pushed the add_telemetry branch from b96abe3 to 2e7b3a8 Mar 22, 2018

@digeff digeff force-pushed the add_telemetry branch from a292d0b to f7a6d0a Mar 22, 2018

@roblourens roblourens merged commit 8965a69 into master Mar 23, 2018

3 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@digeff digeff deleted the add_telemetry branch Mar 23, 2018

@roblourens roblourens added this to the March 2018 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment