New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In pull request description, links are not inline #565

Closed
szhu opened this Issue Oct 9, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@szhu

szhu commented Oct 9, 2018

Issue Type: Bug

What it looks like on GitHub What it looks like in the extension
image image

Note that "readme" and "common mistakes" are on their own line.

Extension version: 0.1.7
VS Code version: Code 1.28.0 (431ef9da3cf88a7e164f9d33bf62695e07c6c2a9, 2018-10-04T16:40:40.180Z)
OS version: Darwin x64 17.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 3
Memory (System) 16.00GB (3.99GB free)
Process Argv -psn_0_40970
Screen Reader no
VM 0%

@szhu szhu changed the title from In pull request description, links have their own line to In pull request description, links are not inline Oct 9, 2018

@RMacfarlane

This comment has been minimized.

Show comment
Hide comment
@RMacfarlane

RMacfarlane Oct 9, 2018

Contributor

@szhu Can you copy and paste the markdown text here?

Contributor

RMacfarlane commented Oct 9, 2018

@szhu Can you copy and paste the markdown text here?

@szhu

This comment has been minimized.

Show comment
Hide comment
@szhu

szhu Oct 9, 2018

<!-- https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29395 -->

Please fill in this template.

- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change. (Run with `npm test`.)
- [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).

If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://www.npmjs.com/package/query-string
- [ ] Increase the version number in the header if appropriate. _Do I need to?_
- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`.

szhu commented Oct 9, 2018

<!-- https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29395 -->

Please fill in this template.

- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change. (Run with `npm test`.)
- [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).
- [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).
- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).

If changing an existing definition:
- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://www.npmjs.com/package/query-string
- [ ] Increase the version number in the header if appropriate. _Do I need to?_
- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`.

@misolori misolori self-assigned this Oct 9, 2018

@misolori misolori closed this in 8dbd37c Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment