Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename `pep8` linter to `pycodestyle` #410

Closed
jeffwidman opened this issue Dec 12, 2017 · 4 comments

Comments

@jeffwidman
Copy link

commented Dec 12, 2017

The pep8 tool was renamed to pycodestyle.

Historical background detailed in this ticket (from before I switched from Atom to VSCode): AtomLinter/linter-pycodestyle#55

The python.linting.pep8* options in this linter should probably be renamed to python.linting.pycodestyle* to reduce confusion in the future.

Happy to help update the extension, but I'm not sure of your policy on deprecating/migrating settings to new names...??

@brettcannon

This comment has been minimized.

Copy link
Member

commented Dec 13, 2017

In this instance we would probably implement the new options and then leave the old ones deprecated for several releases until removing them.

@mizzao

This comment has been minimized.

Copy link

commented Mar 5, 2018

See also DonJayamanne/pythonVSCode#808

@brettcannon brettcannon added needs PR and removed needs decision labels Mar 26, 2018
@DonJayamanne DonJayamanne added this to the April 2018 milestone Mar 26, 2018
@DonJayamanne DonJayamanne modified the milestones: April 2018, May 2018 Apr 26, 2018
@brettcannon brettcannon removed this from the May 2018 milestone Jun 6, 2018
@brettcannon brettcannon changed the title `pep8` linter was renamed to `pycodestyle` rename `pep8` linter to `pycodestyle` Jul 28, 2018
@arnauldvm

This comment has been minimized.

Copy link

commented Mar 15, 2019

I managed to workaround like this:

  • instal pycodestyle (no need to install pep8)
  • add this to settings.json:
    "python.linting.pep8Path": "pycodestyle", // workaround to use pycodestyle instead of pep8
  • select pep8 as linter
@karrtikr karrtikr added this to the September sprint 2019.1 milestone Aug 28, 2019
ericsnowcurrently added a commit that referenced this issue Aug 29, 2019
(for #410)
@kimadeline

This comment has been minimized.

Copy link

commented Aug 29, 2019

Validated:

  • No pep8* settings, pycodestyle settings are available (in the UI and in a local .vscode/settings.json)
  • Setting up linting with pycodestyle for the first time works
  • Migrating from pep8 to `pycodestyle works
  • Linting with pycodestyle works
@kimadeline kimadeline closed this Aug 29, 2019
@pvscbot pvscbot removed the needs PR label Aug 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.