Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change activation of conda environments in powershell #668

Closed
DonJayamanne opened this issue Jan 31, 2018 · 4 comments

Comments

@DonJayamanne
Copy link

commented Jan 31, 2018

Once the upstream Conda Issue #626 is resolved, we'll need to update the conda activation accordingly.

@kalefranz

This comment has been minimized.

Copy link

commented Jun 7, 2018

A contributed powershell wrapper to conda would be hugely appreciated. With conda 4.4+, there are five other shell wrappers for conda. We're still obviously missing powershell.

I started the conda/conda#6471 PR as a sketch of what the powershell wrapper might look like, and Steve Dower added some additional comments in conda/conda#6471 (comment).

Eager to work with anyone wanting to push this through and get it in.

@DonJayamanne

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

Prescribed solution:

    public async getPowershellCommands(
        _envName: string,
        _targetShell: TerminalShellType
    ): Promise<string[] | undefined> {
        return;
    }
  • Modify to send the command conda activate xxx
  • Assumption - Powershell has been configured on user environment for conda.
@tonyxwz

This comment has been minimized.

Copy link

commented Mar 5, 2019

My current solution is to add the following to workspace setting,

{
"terminal.integrated.shellArgs.windows": [
        "-NoExit",
        "-Command",
        "conda activate pyHIFU"
    ],
    "python.terminal.activateEnvironment": false
}

where pyHIFU is my environment name.

@DonJayamanne DonJayamanne removed this from the 2019, week 9 - Feb Sprint 5 milestone Mar 13, 2019

@DonJayamanne DonJayamanne referenced this issue Apr 17, 2019

Open

Conda Issues #5344

1 of 8 tasks complete

@DonJayamanne DonJayamanne self-assigned this Apr 24, 2019

@DonJayamanne DonJayamanne removed their assignment May 29, 2019

@DonJayamanne DonJayamanne added this to the 2019 - June Sprint 12 milestone Jun 12, 2019

@DonJayamanne DonJayamanne self-assigned this Jun 13, 2019

@karrtikr

This comment has been minimized.

Copy link

commented Jun 18, 2019

Given powershell has been configured on user environment for conda and conda activate <envName> works on powershell, validated.

@karrtikr karrtikr closed this Jun 18, 2019

@pvscbot pvscbot removed the needs PR label Jun 18, 2019

@DonJayamanne DonJayamanne referenced this issue Jun 20, 2019

Merged

Fixes to conda activation #6261

3 of 3 tasks complete

@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.