New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be able to specify the path to pipenv #978

Closed
brettcannon opened this Issue Mar 7, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@brettcannon
Copy link
Member

brettcannon commented Mar 7, 2018

As of pypa/pipenv#1474 (in 11.1.2), pipenv added support for -m execution (although there are other issues on Windows currently preventing me from verifying that it works). Once we can verify this works, we can then change our commands to use python -m pipenv and thus work on Windows more easily.

@techalchemy

This comment has been minimized.

Copy link

techalchemy commented Mar 7, 2018

@brettcannon if we can track the other related issues affecting windows we can try to fast-track those fixes (I am using windows primarily as well) -- just tag me and I can triage

@brettcannon

This comment has been minimized.

Copy link
Member Author

brettcannon commented Mar 7, 2018

@techalchemy pypa/pipenv#1587 is the latest issue I have bumped up against on Windows. And thanks for the offer to help! I'm happy to keep trying until I don't run into any bugs. 😉

techalchemy added a commit to techalchemy/pew that referenced this issue Mar 8, 2018

Remove dependence on PSUtil
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and Microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls

techalchemy added a commit to techalchemy/pew that referenced this issue Mar 8, 2018

Remove dependence on PSUtil
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and Microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls

@brettcannon brettcannon self-assigned this Mar 12, 2018

@brettcannon

This comment has been minimized.

Copy link
Member Author

brettcannon commented Mar 13, 2018

This seems to be working now so we can consider adding support for this.

@brettcannon brettcannon removed their assignment Mar 13, 2018

@brettcannon brettcannon referenced this issue Mar 26, 2018

Closed

Release plan for 2018.3.0 #985

43 of 43 tasks complete

techalchemy added a commit to techalchemy/pew that referenced this issue Mar 27, 2018

Remove dependence on PSUtil
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and Microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls

@brettcannon brettcannon referenced this issue Mar 29, 2018

Closed

Release plan for 2018.4.0 #1238

54 of 54 tasks complete

techalchemy added a commit to techalchemy/pew that referenced this issue Apr 20, 2018

Remove dependence on PSUtil
- Use native ctypes for parent process traversal
- Addresses issues raised in pypa/pipenv#1587
  and Microsoft/vscode-python#978
- Improves speed on windows
- Allows pipenv to remove vendored psutil which sometimes fails to find
linked python dlls
@brettcannon

This comment has been minimized.

Copy link
Member Author

brettcannon commented Apr 26, 2018

And if we choose not to do this then we should provide a setting for specifying the path to pipenv.

@brettcannon brettcannon changed the title Update pipenv support to use `-m` Update pipenv support to use `-m` (or be able to specify the path to pipenv) Apr 26, 2018

@brettcannon brettcannon added the x-pipenv label May 2, 2018

@brettcannon brettcannon added this to the May 2018 milestone May 8, 2018

@brettcannon brettcannon removed this from the May 2018 milestone May 24, 2018

@brettcannon brettcannon changed the title Update pipenv support to use `-m` (or be able to specify the path to pipenv) be able to specify the path to pipenv Jun 6, 2018

@brettcannon brettcannon removed the x-pipenv label Nov 20, 2018

@ericsnowcurrently ericsnowcurrently self-assigned this Jan 9, 2019

@pvscbot pvscbot removed the needs PR label Jan 11, 2019

ericsnowcurrently added a commit that referenced this issue Jan 11, 2019

@DonJayamanne

This comment has been minimized.

Copy link

DonJayamanne commented Jan 11, 2019

@ericsnowcurrently
There are a few issues, with the needed code (or at least one) I must have accidentally approved this when submitting my review comments.

@DonJayamanne

This comment has been minimized.

Copy link

DonJayamanne commented Jan 11, 2019

Please check comments in PR
#3957 (comment)

@DonJayamanne DonJayamanne referenced this issue Jan 28, 2019

Closed

Bug Bash Jan 2019.1 Release #4175

65 of 143 tasks complete

@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.