New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for debugging node-tap tests in VSCode #128

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@trivikr
Contributor

trivikr commented Sep 8, 2018

Refs: #125

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Sep 8, 2018

CLA assistant check
All CLA requirements met.

msftclas commented Sep 8, 2018

CLA assistant check
All CLA requirements met.

@trivikr

This comment has been minimized.

Show comment
Hide comment
@trivikr

trivikr Sep 15, 2018

Contributor

Any update on this PR?

Contributor

trivikr commented Sep 15, 2018

Any update on this PR?

@auchenberg

This comment has been minimized.

Show comment
Hide comment
@auchenberg

auchenberg Sep 16, 2018

Collaborator

This PR seems to be a copy/paste of the Jest recipe. What's the specific's to node-tap?

Collaborator

auchenberg commented Sep 16, 2018

This PR seems to be a copy/paste of the Jest recipe. What's the specific's to node-tap?

@trivikr

This comment has been minimized.

Show comment
Hide comment
@trivikr

trivikr Sep 16, 2018

Contributor

The launch configuration is different for node-tap:

{
    "type": "node",
    "request": "launch",
    "name": "Tap current file",
    "program": "${workspaceFolder}/${relativeFile}",
    "cwd": "${workspaceFolder}"
}

In case of Jest, the launch configuration is:

{
    "type": "node",
    "request": "launch",
    "name": "Jest Current File",
    "program": "${workspaceFolder}/node_modules/jest/bin/jest",
    "args": [
        "${relativeFile}"
    ],
    "console": "integratedTerminal",
    "internalConsoleOptions": "neverOpen"
}
Contributor

trivikr commented Sep 16, 2018

The launch configuration is different for node-tap:

{
    "type": "node",
    "request": "launch",
    "name": "Tap current file",
    "program": "${workspaceFolder}/${relativeFile}",
    "cwd": "${workspaceFolder}"
}

In case of Jest, the launch configuration is:

{
    "type": "node",
    "request": "launch",
    "name": "Jest Current File",
    "program": "${workspaceFolder}/node_modules/jest/bin/jest",
    "args": [
        "${relativeFile}"
    ],
    "console": "integratedTerminal",
    "internalConsoleOptions": "neverOpen"
}
@auchenberg

This comment has been minimized.

Show comment
Hide comment
@auchenberg

auchenberg Sep 17, 2018

Collaborator

LGTM

Collaborator

auchenberg commented Sep 17, 2018

LGTM

@auchenberg auchenberg merged commit 6626b6e into Microsoft:master Sep 17, 2018

1 check passed

license/cla All CLA requirements met.
Details

@trivikr trivikr deleted the trivikr:vscode-recipe-tap branch Sep 17, 2018

@auchenberg auchenberg added this to the September 2018 milestone Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment