New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications to angular flow #177

Merged
merged 2 commits into from Feb 4, 2019

Conversation

Projects
None yet
4 participants
@CannibalKush
Copy link
Contributor

CannibalKush commented Dec 6, 2018

Microsoft/vscode#64447

The tutorial as it stands creates a bit of ambiguity by defining a problem matcher for a background task, but not running the task in the background. Also, ng serve task was not defined as a preLaunch task. The guide instructed a user to follow a clunky flow.

Also, "identifiers" are deprecated and serve only to confuse new users. Therefore updated.

CannibalKush added some commits Dec 6, 2018

ng serve and background task
Microsoft/vscode#64447

The tutorial as it stands creates a bit of ambiguity by defining a problem matcher for a background task, but not running the task in the background. Also, ng serve task was not defined as a preLaunch task. The guide instructed a user to follow a clunky flow.

Also, "identifiers" are deprecated and serve only to confuse new users. Therefore updated.
Update README.md
fix regex and ordering
@msftclas

This comment has been minimized.

Copy link

msftclas commented Dec 6, 2018

CLA assistant check
All CLA requirements met.

@CannibalKush

This comment has been minimized.

Copy link
Contributor Author

CannibalKush commented Dec 6, 2018

The guy that made volkswagen-lib is reviewing my PR, sick.

@CannibalKush

This comment has been minimized.

Copy link
Contributor Author

CannibalKush commented Dec 6, 2018

Fixes #159

@weinand

This comment has been minimized.

Copy link
Member

weinand commented Dec 6, 2018

Thanks for the great PR. Looks good to me.
@tonysneed Ok for you as well?

@auchenberg auchenberg merged commit 1b8c512 into Microsoft:master Feb 4, 2019

1 check passed

license/cla All CLA requirements met.
Details

@auchenberg auchenberg added this to the Dec/Jan 2019 milestone Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment