Add jsEnable option #154

Merged
merged 2 commits into from Jan 6, 2017

Projects

None yet

3 participants

@YuichiNukiyama
Contributor

fixes #149

@sqren
sqren commented Dec 29, 2016

Looking forward to this being merged in.

@egamma egamma merged commit dda451f into Microsoft:master Jan 6, 2017
@YuichiNukiyama YuichiNukiyama deleted the YuichiNukiyama:jsenable_option branch Jan 6, 2017
@egamma
Member
egamma commented Jan 9, 2017 edited

@YuichiNukiyama thanks ๐ŸŒท for the PR . I've published it as part of vscode-tslint 0.8.1. I've changed the default to false, since users where confused that tslint is active by default on .js files.

We should revisit the implementation once the language server protocol 3.0 is out. With this protocol version we can dynamically change the configuration so that .js files are not synchronized to the server, when jsEnabled is set to false. The current implementation always syncs over the JS files and then just ignores them when jsEnabled is set to false.

@egamma egamma added this to the January 2015 milestone Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment