Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsEnable option #154

Merged
merged 2 commits into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@YuichiNukiyama
Copy link
Contributor

commented Dec 22, 2016

fixes #149

@sqren

This comment has been minimized.

Copy link

commented Dec 29, 2016

Looking forward to this being merged in.

@egamma egamma merged commit dda451f into microsoft:master Jan 6, 2017

@YuichiNukiyama YuichiNukiyama deleted the YuichiNukiyama:jsenable_option branch Jan 6, 2017

@egamma

This comment has been minimized.

Copy link
Member

commented Jan 9, 2017

@YuichiNukiyama thanks 🌷 for the PR . I've published it as part of vscode-tslint 0.8.1. I've changed the default to false, since users where confused that tslint is active by default on .js files.

We should revisit the implementation once the language server protocol 3.0 is out. With this protocol version we can dynamically change the configuration so that .js files are not synchronized to the server, when jsEnabled is set to false. The current implementation always syncs over the JS files and then just ignores them when jsEnabled is set to false.

@egamma egamma added this to the January 2015 milestone Jan 26, 2017

@egamma

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

@jacobbogers what issue do you exactly refer to? The PR is about enabling a jsEnable option and this is in place since a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.