New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show: add icon fallback on win32 #226

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@raix
Contributor

raix commented Dec 6, 2017

Both cmd and powershell fails to render the super nice unicode stars. It breaks my hearts... to make windows users use a fallback.

The issue circles unicode glyphs not in raster etc. fonts and the use of charpages.

fixes #221

fix show: add icon fallback on win32
Both cmd and powershell fails to render the super nice unicode stars. It breaks my hearts... to make windows users use a fallback.

The issue circles unicode glyphs not in raster etc. fonts and the use of charpages.

fixes #221

@joaomoreno joaomoreno self-assigned this Dec 7, 2017

@joaomoreno joaomoreno added this to the Backlog milestone Dec 7, 2017

@joaomoreno

Yeah that's really too bad!

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Dec 7, 2017

Member

Thanks! 🍻

Member

joaomoreno commented Dec 7, 2017

Thanks! 🍻

@joaomoreno joaomoreno merged commit d155534 into Microsoft:master Dec 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment