New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Yarn use in package command #260

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
2 participants
@kevcunnane
Member

kevcunnane commented May 3, 2018

This fixes an issue where npm list thinks dependencies are invalid,
but a project uses Yarn and this can correctly handle the dependencies.
This is blocking SQL Ops Studio extensions that rely on
https://github.com/anthonydresser/dataprotocol-client, as this is marked
as invalid and essentially requires use of Yarn.

Please let me know if there's anything I should be doing in terms of testing etc. to help validate this. The basic test of using vsce package --yarn worked as expected and no longer caused packaging to fail.

Support Yarn use in package command
This fixes an issue where `npm list` thinks dependencies are invalid,
but a project uses Yarn and this can correctly handle the dependencies.
This is blocking SQL Ops Studio extensions that rely on
https://github.com/anthonydresser/dataprotocol-client, as this is marked
as invalid and essentially requires use of Yarn.

@joaomoreno joaomoreno added this to the Backlog milestone May 3, 2018

@joaomoreno joaomoreno self-assigned this May 3, 2018

@joaomoreno joaomoreno merged commit a70271e into Microsoft:master May 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Member

joaomoreno commented May 3, 2018

Looks great, thanks! v1.40.0 is on the way of being built: https://travis-ci.org/Microsoft/vscode-vsce/builds/374278813. Let me know how it goes for you.

@kevcunnane

This comment has been minimized.

Member

kevcunnane commented May 3, 2018

Works great, thanks for the quick turnaround!

@joaomoreno joaomoreno modified the milestones: Backlog, June 2018 Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment