New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to publish using 'npm version' #263

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@JimiC
Contributor

JimiC commented Jun 2, 2018

Resolves #206
References #180

As per popular request vsce publish <version> will now use npm version <version>, in order to bump the package version. In the process, package-lock.json will also be updated (when using npm5+) and tagged git commit will be done (supporting gpg signing when it's set in git config).

Note: As before only major, minor and patch are supported as a valid <version>.

I refrained from implementing a rollback of the process, as if anything goes wrong after the version bump (i.e. network issues), the user can simply execute vsce publish (without <version>) and complete the publishing.

This implementation also does not interfere with using plain vsce publish via a CI service. The user, in that case, should perform npm version <version> locally. Then push the commit and the tag. The CI publishing stage should only call vsce publish -p <token>.

@joaomoreno joaomoreno added this to the Backlog milestone Jun 4, 2018

@joaomoreno joaomoreno self-assigned this Jun 4, 2018

@joaomoreno joaomoreno merged commit 8ad048a into Microsoft:master Jun 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Member

joaomoreno commented Jun 4, 2018

Works great for me!

@joaomoreno joaomoreno modified the milestones: Backlog, June 2018 Jul 2, 2018

@JimiC JimiC deleted the JimiC:publish-using-npm-version branch Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment