New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish with specific version #307

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
5 participants
@kondratyev-nv
Copy link
Contributor

kondratyev-nv commented Nov 30, 2018

Fixes #305

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 30, 2018

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno self-assigned this Nov 30, 2018

@joaomoreno joaomoreno added this to the November 2018 milestone Nov 30, 2018

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 30, 2018

Thanks! 🍻

@joaomoreno joaomoreno merged commit 6d58bca into Microsoft:master Nov 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@iciclesoft

This comment has been minimized.

Copy link

iciclesoft commented Dec 29, 2018

Exactly what I need! Any idea when this will be released?

@nwolverson

This comment has been minimized.

Copy link

nwolverson commented Jan 3, 2019

I suspect this has already been released, this has broken my previous workflow of versioning with npm and then running vsce publish <version> with the already tagged version. I don't remember why I was doing that though, probably working around an issue in a super ancient version of vsce...

(Tags on this repo are not up to date with npm released versions)

@iciclesoft

This comment has been minimized.

Copy link

iciclesoft commented Jan 3, 2019

Yeah apparantly version 1.54.0 is already released, but not visible on https://github.com/Microsoft/vscode-vsce/releases
Thanks though!

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 4, 2019

Yeah I must've forgotten to git push on my office machine. I'll sync those changes up next week.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 7, 2019

Pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment