New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colors to console messages #324

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@usernamehw
Copy link
Contributor

usernamehw commented Jan 14, 2019

Fixes #323

Didn't test the message itself on macOS.

Also didn't test it in general since I don't know how.

@joaomoreno
Copy link
Member

joaomoreno left a comment

We definitely don't want to do this if the output stream isn't a TTY.

I suggest to just depend on chalk or similar.

@usernamehw

This comment has been minimized.

Copy link
Contributor Author

usernamehw commented Jan 15, 2019

Should I bring back Successfully word?

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 16, 2019

Nah, it's good without. 👍

@joaomoreno joaomoreno self-assigned this Jan 16, 2019

@joaomoreno joaomoreno added this to the December/January 2019 milestone Jan 16, 2019

@joaomoreno
Copy link
Member

joaomoreno left a comment

We don't need @types/chalk:

npm WARN deprecated @types/chalk@2.2.0: This is a stub types definition for chalk (https://github.com/chalk/chalk). chalk provides its own type definitions, so you don't need @types/chalk installed!

I've also rewritten how the util looks like. I'd rather have functions we can call rather than consts we have to add to strings.

@joaomoreno joaomoreno merged commit a86fc10 into Microsoft:master Jan 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jan 16, 2019

Thanks! 🍻

@usernamehw usernamehw deleted the usernamehw:console_colors branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment