New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review actions that should persist their state into settings #13328

Closed
egamma opened this Issue Oct 7, 2016 · 8 comments

Comments

Projects
None yet
7 participants
@egamma
Member

egamma commented Oct 7, 2016

  • zoom - setting
  • sidebar location - setting
  • status bar visibility - setting
  • toggle whitespace - not a setting
  • toggle wordwrap - not a setting
  • toggle control charactes - not a setting

@egamma egamma added the plan-item label Oct 7, 2016

@egamma egamma added this to the October 2016 milestone Oct 7, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 7, 2016

Member

I pushed:

Member

bpasero commented Oct 7, 2016

I pushed:

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 7, 2016

Member

I am not 100% convinced we should blindly write to settings for word wrap, white space etc. because other editors seem to apply this only for the current file and not all files. If I have 2 files side by side open and I click on word wrap for the left file (because it could be a markdown file), I would NOT expect word wrap to be enabled for the other file which could be any source file where word wrap does not make sense.

Member

bpasero commented Oct 7, 2016

I am not 100% convinced we should blindly write to settings for word wrap, white space etc. because other editors seem to apply this only for the current file and not all files. If I have 2 files side by side open and I click on word wrap for the left file (because it could be a markdown file), I would NOT expect word wrap to be enabled for the other file which could be any source file where word wrap does not make sense.

@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Oct 7, 2016

Member

Make sense to distinguish settings that are temporary and per buffer only.

To me toggle status bar falls into the same category as the sidebar location.

Let's have an inventory at the top in the description.

Member

egamma commented Oct 7, 2016

Make sense to distinguish settings that are temporary and per buffer only.

To me toggle status bar falls into the same category as the sidebar location.

Let's have an inventory at the top in the description.

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Oct 7, 2016

Member

I'd like to add

  • diff editor, show leading/trailing whitespace changes
  • diff editor, sideBySide vs inline diff
Member

jrieken commented Oct 7, 2016

I'd like to add

  • diff editor, show leading/trailing whitespace changes
  • diff editor, sideBySide vs inline diff

bpasero added a commit that referenced this issue Oct 13, 2016

@Bill-Stewart

This comment has been minimized.

Show comment
Hide comment
@Bill-Stewart

Bill-Stewart Oct 14, 2016

Yes, it is very helpful to have different settings per buffer (preferably by file type).

Bill-Stewart commented Oct 14, 2016

Yes, it is very helpful to have different settings per buffer (preferably by file type).

@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Oct 21, 2016

Member

Reopening to track the work on the diff editor related commands.

Member

egamma commented Oct 21, 2016

Reopening to track the work on the diff editor related commands.

@egamma egamma reopened this Oct 21, 2016

@bpasero bpasero removed their assignment Oct 21, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 24, 2016

Member

I added test plan and release notes for zoom, status bar visibility and sidebar location.

Member

bpasero commented Oct 24, 2016

I added test plan and release notes for zoom, status bar visibility and sidebar location.

@bpasero bpasero modified the milestones: October 2016, November 2016 Oct 28, 2016

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Dec 7, 2016

Member

@bpasero Can this be closed or is there anything pending to be done?

Member

ramya-rao-a commented Dec 7, 2016

@bpasero Can this be closed or is there anything pending to be done?

@bpasero bpasero closed this Dec 8, 2016

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.