New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on 1.6.0 Linux 64-bit #13487
Comments
|
Clean your repository and try again: |
|
Not a git repo build. |
|
What are you trying to build? |
|
Visual Studio Code? Is there something else from you guys that I would be building? |
|
For more information:
|
|
[https://github.com/Microsoft/vscode/blob/master/build/npm/preinstall.js#L29](This code) is responsible for installing |
|
Any chance it has something to do with your fsevents commit that was tagged for 1.6.0, which was the last thing to change on the file? |
|
Confirmed, your removal of the |
|
No. This code is responsible for installing Ultimately, If your |
"Works for me" ethos? The idea in reporting an issue is to interactively debug the issue, not to tell the OP to find out themselves why the thing they've reported is broken, in your software.
This is built in an isolated chroot, there is no global to build against. The resulting build is clean and functional. |
|
I would... it's just that it doesn't reproduce for me, making it very hard to know what's going on. And it also happens not to reproduce in anyone else's machine. So... yeah... you'd have to figure it out. Or give me SSH access and I'll do it for you. If you just want to work around it, you can do right after |
And I did. Then you told me to dig through the log to check if it's running the preinstall hook, which you could've gotten from the full log I quite literally linked in the first comment. These are reproducible builds. The log isn't going to be different, and what you get is whatever output our tooling provides as well as whatever yours does. Already fixed downstream with a patch to revert your change to the package.json. |
|
Sure I looked into your full log... but there's nothing there related to our Something is different between what your tooling does, compared to ours. Just look at our Travis builds, for example, How can I further help? |
|
Actually, there is: Any idea what |
|
Here are a few hints: TryGhost/Ghost#6754 So, does adding |
|
Can confirm that appending |
|
Added a note to https://github.com/Microsoft/vscode/wiki/How-to-Contribute. Automatically adding the flag when running as root would defeat the purpose of having the flag at all, which exists exactly for this purpose: making sure users know that what they are doing is not safe. |
|
|

This wasn't an issue prior to 1.6.0. As of 1.6.0, the follow error occurs on and thus build fails:
Full log:
For reference, the build bits (important and relevant bits here) of our package.yml are:
Other potential helpful bits:
NPM version: 3.10.3
nodejs version: 6.7.0
The text was updated successfully, but these errors were encountered: