New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Scrolling is not smooth but lags #13612

Closed
niagr opened this Issue Oct 12, 2016 · 246 comments

Comments

Projects
None yet
@niagr
Copy link

niagr commented Oct 12, 2016

Edit: Added the workaround:

Workaround

Configure:

  • "window.smoothScrollingWorkaround": true
  • "window.titleBarStyle": "native"
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Oct 12, 2016

Did not see this on my VM, assignig to @Tyriar to check if he also sees it on his linux so we assess how serios it is

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Oct 12, 2016

I don't have my Linux laptop with me at the moment, I'll mark this October to remind me. /cc @alexandrudima

@Tyriar Tyriar added this to the October 2016 milestone Oct 12, 2016

@jshap70

This comment has been minimized.

Copy link

jshap70 commented Oct 13, 2016

I have this to, though it isn't present everywhere. The tree view panel and all the editors no longer smooth scroll, but entries which (I assume) are probably using browser rendering, like extension detail pages, do still smooth scroll.

running:
arch linux - x86_64 Linux 4.7.6-1-ARCH
GNOME Shell 3.22.1

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Oct 13, 2016

I can't tell a different on either the tree view or the editor comparing 1.6.0 and 1.5.3 using Ubuntu 16.04. @bpasero @alexandrudima any ideas?

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Oct 14, 2016

Dup of #12637

@isidorn isidorn closed this Oct 14, 2016

@jshap70

This comment has been minimized.

Copy link

jshap70 commented Oct 14, 2016

I don't believe this is a dup of that issue, that issue indicates it doesn't work at all, whereas this issue is purely related to smooth scrolling: 2-finger scrolling works, but acts like regular 'jumpy' scrolling.

@joaomoreno joaomoreno reopened this Oct 14, 2016

@niagr

This comment has been minimized.

Copy link

niagr commented Oct 14, 2016

I agree with @jshap70, this is a different issue as he described.

@jhasse

This comment has been minimized.

Copy link
Contributor

jhasse commented Oct 18, 2016

I think this is a regression in Chromium (I also noticed it there) which was fixed for me in 54.

@Tyriar Tyriar removed this from the October 2016 milestone Oct 18, 2016

@Tyriar Tyriar removed their assignment Oct 18, 2016

@Anheurystics

This comment has been minimized.

Copy link

Anheurystics commented Oct 25, 2016

Can confirm this, using two-finger scrolling for the editor is laggy. Using version 1.6.1 on my Windows 10 machine.

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Oct 25, 2016

AFAIK we had no changes in the scroll handling logic, but we did update to a newer electron version (that includes Chromium 52).

It would be interesting to find out if Chrome 52 also suffers from this issue. We have the exact same scrolling code in the editor https://microsoft.github.io/monaco-editor/ so if anyone would like to try it and report here the findings, I would be thankful.

There are plenty of touchpads issues on Chromium: https://bugs.chromium.org/p/chromium/issues/list?can=2&q=touchpad

Are we hitting a known issue for them?

@jshap70

This comment has been minimized.

Copy link

jshap70 commented Oct 25, 2016

The scrolling in monaco is smooth and feels just like vscode did before for me inside Chrome (beta) 55.0.2883.21 as well as Chromium 54.0.2840.71.
I just built a version of Chromium 52.0.2743.85 to test, and can confirm that it has the same jumpy scrolling. Using monaco inside of it is especially rough. This confirms the idea that it's probably an electron bug and not a vscode bug. bummer.

@alexandrudima

This comment has been minimized.

Copy link
Member

alexandrudima commented Oct 26, 2016

@jshap70 Thank you very much for confirming this is a Chromium bug that will get fixed once we get a newer version. fyi @bpasero

I've also experienced this today on my Surface Book. It is a real bummer. Most weird, after using a mouse for a bit, the trackpad was working normally again. I'm sorry there's nothing I can do on our side, we get mousewheel events and respect them when we get them.

@bpasero bpasero added this to the On Deck milestone Sep 3, 2018

@gurpreetshanky

This comment has been minimized.

Copy link

gurpreetshanky commented Sep 3, 2018

@bpasero Yes the problem is solved with 17751.1 on Dell XPS 15 with precision touchpad.

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Sep 3, 2018

Out of curiosity: did anyone ever hit this issue on Windows 7 or Windows 8? I am asking because the fix will probably only ever be made on Windows 10.

@sywesk

This comment has been minimized.

Copy link

sywesk commented Sep 3, 2018

@bpasero I don't think it would happen on earlier versions of windows because they didn't support precision touchpads, if I remember well.

@bdr99

This comment has been minimized.

Copy link

bdr99 commented Sep 5, 2018

Will this change be present in the Windows 10 October 2018 Update when it is released?

@SHAHIN-PC

This comment has been minimized.

Copy link

SHAHIN-PC commented Sep 5, 2018

My hp desktop pc power is on for one minute but monitors are not open and mouse or keyboard has been not working when updated my windows 10 before two years ago

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Sep 6, 2018

@bdr99 yes it will be available as part of the October update.

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Oct 15, 2018

Closing this as the Windows 10 October update is rolling out to people. This bug is fixed as part of the Windows 10 RS5 update.

@bpasero bpasero closed this Oct 15, 2018

@bpasero bpasero modified the milestones: On Deck, October 2018 Oct 15, 2018

@rroyGit

This comment has been minimized.

Copy link

rroyGit commented Oct 22, 2018

Awesome, now have to wait for RS5 - hopefully tomorrow.

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Nov 6, 2018

We decided to keep the "window.smoothScrollingWorkaround": true for this release and we plan to remove it in the future when more users update to the latest Windows.
Can somebody who does not have the latest Windows 10 version please take this insider build and verify that the window.smoothScrollingWorkaround works as before and that scrolling is smooth? I would really appreciate it.

https://az764295.vo.msecnd.net/insider/1d0e4299c6ccfe9210252c811b4247cfdc8a6a44/VSCodeSetup-ia32-1.29.0-insider.exe
https://az764295.vo.msecnd.net/insider/340133accd0b66202bde342f995f00b02f63c0d4/VSCodeSetup-x64-1.30.0-insider.exe

@Microsoft Microsoft unlocked this conversation Nov 6, 2018

@HazemAM

This comment has been minimized.

Copy link

HazemAM commented Nov 7, 2018

@isidorn I don't have the October update installed yet, so I installed the insider build to test.

But thing is, the KB4462933 update fixed the issue for me. Now there's no difference between stable/insider builds, and with/without window.smoothScrollingWorkaround after the update.

Here are more testimonials: #62327 (comment), #61824 (comment).

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Nov 7, 2018

@HazemAM thanks for jumping it!
That is why I need somebody who does not have the latest windows update to try it out so we can verify that the setting still works.

@HazemAM

This comment has been minimized.

Copy link

HazemAM commented Nov 7, 2018

@isidorn Oh, so you meant the latest incremental update, not the October update?

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Nov 7, 2018

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 19, 2018

Keep in mind that it is not enough to just configure window.smoothScrollingWorkaround: true, you will also have to disable the custom title via window.titleBarStyle: native.

@skn3

This comment has been minimized.

Copy link

skn3 commented Nov 26, 2018

I have no available windows updates to install (I am up to date), latest vscode and I am running bootcamp windows.

When using the trackpad, there is absolutely no way (with any of the combination of suggestions in this thread) to get smooth scrolling working. Vscode ignores my control panel mouse wheel settings. The only way I can get vscode to behave is by setting the "editor.mouseWheelScrollSensitivity": 0.2 however I switch between using a trackpad and a mouse, so I have to change this setting every time I switch device!

At the minute vscode is pretty unbearable to use because of this!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.