New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle mouse click on taskbar icon doesn't open a new window #13905

Closed
cozzbp opened this Issue Oct 17, 2016 · 13 comments

Comments

Projects
None yet
10 participants
@cozzbp
Copy link

cozzbp commented Oct 17, 2016

  • VSCode Version: Code 1.6.1 (9e4e44c, 2016-10-13T16:21:53.542Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: abotteram.typescript-react-snippets-0.1.9, hars.CppSnippets-0.0.5, lukehoban.Go-0.6.44, ms-vscode.cpptools-0.9.2

Steps to Reproduce:

  1. Middle click on running VS Code icon on the taskbar, it doesn't open a new window like many programs
  2. You can open a new window by right clicking the icon and choosing "New Window"
@jhasse

This comment has been minimized.

Copy link
Contributor

jhasse commented Oct 18, 2016

Related: When working with multiple workspaces, clicking on VS Code in the taskbar on a workspace where it hasn't been started yet switches to a running instance on another workspace instead of starting a new one.

@bpasero bpasero added the help wanted label Oct 27, 2016

@peredin

This comment has been minimized.

Copy link

peredin commented Nov 10, 2016

This has to be fixed, very annoying now that Windows finally has multiple virtual desktops natively.

VS Code should automatically open a new window upon execution. This way, Windows will take care of activating an existing window unless shift is held while clicking the button, or, opening a new VS Code window.

@cozzbp

This comment has been minimized.

Copy link

cozzbp commented Nov 10, 2016

It may actually be a problem with electron apps in general. Postman also exhibits this behavior.

@the-ress

This comment has been minimized.

Copy link
Contributor

the-ress commented Nov 10, 2016

I think it should be done by setting System.AppUserModel.RelaunchCommand with -n argument.

It will need to be implemented in Electron (like e.g. jump lists).

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Apr 3, 2017

Depends on #23842

@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Apr 27, 2017

  • VSCode Version: Code - Insiders 1.12.0-insider (d8a1d8b, 2017-04-27T06:12:15.095Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: none

'New Window' works, but middle click and Shift + left click still don't.

@chrmarti chrmarti reopened this Apr 27, 2017

@the-ress

This comment has been minimized.

Copy link
Contributor

the-ress commented Apr 27, 2017

I've just finished some investigation into this. It works when launch VSCode using scripts\code.bat, but not when I build VSCodeSetup.exe and install it.

The shortcut in start menu (which has the same AppUserModelID as the window) seems to take priority over the RelaunchCommand value. (I couldn't find any way to override this.)

AppUserModelID of the shortcut and the window needs to match so they share one MFU list and jump list.

Only solution I can think of is to add the -n argument to the start menu shortcut too.

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Apr 28, 2017

I am a bit confused, I could swear I tested this. But probably only from a local built VS Code, never when going through the setup. Too bad...

@todorm85

This comment has been minimized.

Copy link

todorm85 commented Dec 5, 2017

Had similar issue with sublime, managed to get it working by adding the -noframemerging switch to the target of the shortcut. Right click on shortcut to vscode, go to shortcut tab and in target add -noframemerging after the path to the executable (should be outside the quotes).

@dmrickey

This comment has been minimized.

Copy link

dmrickey commented Mar 1, 2018

How is this still a thing?

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Mar 7, 2018

@the-ress I cannot really explain it but with our current insiders release, middle-click on the taskbar opens a new window for me (stable does not work).

Can others try to reproduce this with our insiders: https://code.visualstudio.com/insiders/

I am very confused what change could have an impact :-/

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Mar 7, 2018

Wow, now I am back to having it NOT working in insiders, this is very weird....

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Mar 9, 2018

Fixed via #45322

@bpasero bpasero closed this Mar 9, 2018

@bpasero bpasero added this to the March 2018 milestone Mar 9, 2018

@tsalinger tsalinger added the verified label Mar 28, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.