New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: disablement state needs to be communicated across windows #14372

Closed
bpasero opened this Issue Oct 25, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@bpasero
Copy link
Member

bpasero commented Oct 25, 2016

Testing #14288

  • open one window and disable an extension for the workspace
  • open another window and disable the same extension always

=> the first window still thinks the disabled state is only for the workspace when it was globally disabled

@bpasero bpasero added the bug label Oct 25, 2016

@sandy081 sandy081 added this to the October 2016 milestone Oct 25, 2016

@sandy081 sandy081 added the extensions label Oct 26, 2016

@sandy081 sandy081 modified the milestones: November 2016, October 2016 Oct 26, 2016

@sandy081 sandy081 modified the milestones: January 2017, November 2016 Dec 7, 2016

@sandy081 sandy081 modified the milestones: February 2017, January 2017 Jan 23, 2017

@sandy081 sandy081 modified the milestones: Backlog, February 2017 Feb 21, 2017

@sandy081 sandy081 added the debt label Feb 21, 2017

@sandy081 sandy081 added feature-request and removed bug labels Apr 12, 2017

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Sep 24, 2018

Another dependent of #58957

@sandy081 sandy081 modified the milestones: Backlog, December 2018 Dec 11, 2018

@sandy081 sandy081 closed this in 2272628 Dec 11, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2019

@bpasero bpasero reopened this Jan 29, 2019

@bpasero

This comment has been minimized.

Copy link
Member Author

bpasero commented Jan 29, 2019

I would have expected this to work:

  • open one window with a workspace
  • open extensions view
  • open a second empty window
  • disable an extension globally from the second empty window
  • back in the first window the extension still shows as enabled

image

@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Jan 29, 2019

@bpasero it works for me

kapture 2019-01-30 at 0 07 25

And I cant find the extension you tried

@bpasero

This comment has been minimized.

Copy link
Member Author

bpasero commented Jan 30, 2019

@sandy081 I see it working nicely when disabling the extension globally but this flow still seems broken:

  • disable extension for workspace in one window
  • disable extension globally in other window
  • 🐛 first window still thinks the extension is only disabled for workspace, is that expected?
@sandy081

This comment has been minimized.

Copy link
Member

sandy081 commented Jan 30, 2019

Yes, workspace disabled extensions are not overridden when globally disabled or enabled.

@bpasero bpasero added the verified label Jan 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.