Preserve editor relative sizes when switching layouts #14464

Closed
Tyriar opened this Issue Oct 25, 2016 · 3 comments

Projects

None yet

4 participants

@Tyriar
Member
Tyriar commented Oct 25, 2016

Testing #14016

  • VSCode Version: Code - Insiders 1.7.0-insider (5bafcdb, 2016-10-25T06:19:07.301Z)
  • OS Version: Linux x64 4.4.0-45-generic, Ubuntu 16.04
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.4
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.1.0
terminal-tabs Tyriar 0.0.6
theme-glacier Tyriar 0.0.10
vscode-icontheme-nomo-dark be5invis 1.1.5
vscode-svgviewer cssho 1.2.0
vscode-eslint dbaeumer 1.0.8
git-project-manager felipecaputo 0.1.15
Theme-Wombat gerane 0.0.2
csharp ms-vscode 1.4.1
typescript-javascript-grammar ms-vscode 0.0.6
nova rebornix 0.0.5
sass-indented robinbentley 1.1.0
annotator ryu1kn 0.10.1

Steps to Reproduce:

  1. Open 2 editor groups
  2. "Minimize" one to enable snapping
  3. Toggle editor group layout, the editor groups will both be the default sizes.
@bpasero bpasero was assigned by Tyriar Oct 25, 2016
@rebornix
Member

After the third step @Tyriar mentioned above, if you do a fourth step Toggle editor group layout which switches back the previous layout, snapping state should be retained at least.

@bpasero bpasero changed the title from Editor group snap state should be retained when toggling editor group layout to Preserve editor relative sizes when switching layouts Oct 26, 2016
@bpasero bpasero removed their assignment Oct 26, 2016
@bpasero bpasero removed the workbench-tabs label Oct 28, 2016
@charlespierce
Contributor

I'm interested in tackling this feature request. From a quick look, it appears to be relatively straightforward, but I'm curious if there are any potential pitfalls that immediately jump out to be aware of?

@charlespierce charlespierce added a commit to charlespierce/vscode that referenced this issue Dec 23, 2016
@charlespierce charlespierce #14464 Preserve editor size when switching layout c96175e
@charlespierce charlespierce added a commit to charlespierce/vscode that referenced this issue Jan 4, 2017
@charlespierce charlespierce #14464 Remove KEEP_RATIO from the exposed API 7790ab5
@charlespierce charlespierce added a commit to charlespierce/vscode that referenced this issue Jan 4, 2017
@charlespierce charlespierce #14464 Preserve editor size when switching layout c4347fc
@charlespierce charlespierce added a commit to charlespierce/vscode that referenced this issue Jan 4, 2017
@charlespierce charlespierce #14464 Remove KEEP_RATIO from the exposed API 38038ba
@bpasero bpasero added this to the January 2017 milestone Jan 5, 2017
@bpasero bpasero self-assigned this Jan 5, 2017
@bpasero bpasero closed this Jan 5, 2017
@bpasero
Member
bpasero commented Jan 23, 2017
  • To verify:
    Switch the editor layout and verify the editor dimensions are kept relatively.
@Tyriar Tyriar added the verified label Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment