New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependencies for VSIX extensions #15477

Closed
balajikris opened this Issue Nov 14, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@balajikris

balajikris commented Nov 14, 2016

  • VSCode Version:
Version 1.7.1
Commit 02611b40b24c9df2726ad8b33f5ef5f67ac30b44
Date 2016-11-03T13:53:14.822Z
Shell 1.3.8
Renderer 52.0.2743.82
Node 6.5.0
  • OS Version: Microsoft Windows [Version 10.0.14393]

Problem: specifying “extensionDependencies” in the extension manifest does not work as intended.

Steps to Reproduce:

  1. Open a simple VS Code extension project
  2. In package.json, specify extensionDependencies

In my case, I had this code:

    "extensionDependencies": [
        "samverschueren.yo"
    ]
  1. package the extension as .vsix and import it in another instance of VSCode.

Expected: VSCode extension dependencies are installed
Actual: extension dependencies aren't installed.

Furthermore, if i uninstall my extension, VSCode asks if it should uninstall dependencies as well and if answered yes, extension dependencies are properly removed. This tells me I got the extension name $publisher.$name right. So, it seems to me that, uninstall flow works as expected and install does not. Unless, I'm missing something.

@balajikris balajikris changed the title from 'extensionDependency' does not work as intended to 'extensionDependencies' does not work as intended Nov 14, 2016

@ramya-rao-a

This comment has been minimized.

Show comment
Hide comment
@ramya-rao-a

ramya-rao-a Nov 15, 2016

Member

@balajikris

Furthermore, if i uninstall my extension, VSCode asks if it should uninstall dependencies as well and if answered yes, extension dependencies are properly removed

How are the extension dependencies being removed if they were not installed with the extension which has dependency on it? Was the dependency already installed?

Member

ramya-rao-a commented Nov 15, 2016

@balajikris

Furthermore, if i uninstall my extension, VSCode asks if it should uninstall dependencies as well and if answered yes, extension dependencies are properly removed

How are the extension dependencies being removed if they were not installed with the extension which has dependency on it? Was the dependency already installed?

@balajikris

This comment has been minimized.

Show comment
Hide comment
@balajikris

balajikris Nov 15, 2016

No, I installed the dependency by hand, after noticing that installing my extension didn't bring along the dependencies. While uninstalling mine, I noticed that it asks me for a bundle removal, so I tested that path and found that to work.

balajikris commented Nov 15, 2016

No, I installed the dependency by hand, after noticing that installing my extension didn't bring along the dependencies. While uninstalling mine, I noticed that it asks me for a bundle removal, so I tested that path and found that to work.

@balajikris

This comment has been minimized.

Show comment
Hide comment
@balajikris

balajikris Nov 15, 2016

I also looked at https://github.com/Microsoft/vscode-extension-samples/tree/master/extension-deps-sample and tried the examples suggested there and it didn't help. I still observe the same behavior.

balajikris commented Nov 15, 2016

I also looked at https://github.com/Microsoft/vscode-extension-samples/tree/master/extension-deps-sample and tried the examples suggested there and it didn't help. I still observe the same behavior.

@sandy081 sandy081 added this to the Backlog milestone Nov 16, 2016

@sandy081 sandy081 changed the title from 'extensionDependencies' does not work as intended to Support dependencies for VSIX extensions Nov 16, 2016

@sandy081

This comment has been minimized.

Show comment
Hide comment
@sandy081

sandy081 Nov 16, 2016

Member

@balajikris Installing extension dependencies is not supported when installing as VSIX and not from market place.

Member

sandy081 commented Nov 16, 2016

@balajikris Installing extension dependencies is not supported when installing as VSIX and not from market place.

@balajikris

This comment has been minimized.

Show comment
Hide comment
@balajikris

balajikris Nov 16, 2016

@sandy081 ah I see. thanks for clarifying that. For now, I'll try to test dependency installation in realtime after i upload my extension to the marketplace. I do appreciate you taking this into the backlog, as it just seems to be missing with the vsix workflow.

balajikris commented Nov 16, 2016

@sandy081 ah I see. thanks for clarifying that. For now, I'll try to test dependency installation in realtime after i upload my extension to the marketplace. I do appreciate you taking this into the backlog, as it just seems to be missing with the vsix workflow.

@stef-levesque

This comment has been minimized.

Show comment
Hide comment
@stef-levesque

stef-levesque Jun 14, 2017

Any update on this? I really wish 'extensionDependencies' would work with .vsix, as this is the only way we can deploy our tools at work.

stef-levesque commented Jun 14, 2017

Any update on this? I really wish 'extensionDependencies' would work with .vsix, as this is the only way we can deploy our tools at work.

@sandy081 sandy081 modified the milestones: June 2017, Backlog Jun 15, 2017

@sandy081 sandy081 modified the milestones: July 2017, June 2017 Jun 28, 2017

@sandy081 sandy081 modified the milestones: August 2017, July 2017 Jul 25, 2017

@sandy081 sandy081 modified the milestones: Backlog, August 2017 Aug 22, 2017

@sandy081 sandy081 modified the milestones: Backlog, November 2017 Nov 20, 2017

@sandy081 sandy081 closed this in 70900a5 Nov 21, 2017

@aeschli aeschli added verified and removed verification-needed labels Dec 5, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.