New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ordering to title menu items. #15596

Closed
mdickin opened this Issue Nov 16, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@mdickin

mdickin commented Nov 16, 2016

  • VSCode Version: 1.7.1
  • OS Version: Windows 8.1

Steps to Reproduce:

  1. Create a new VSCode extension
  2. Define commands in the package.json for "Toggle Bold", "Toggle Italics", and "Toggle Bullets", complete with icons.
  3. Add these commands to the "editor/title" menu
  4. Load Code with this extension installed
  5. Note that the order of icons is changed, with the Bullets icon between Bold and Italic.

image

From what I can tell, the ordering of items is strictly by the name of the command. However, this is less than ideal, as it looks strange having Bold and Italic separated. I considered changing the names of the commands to control order, but this would look strange when presented to the user.

I ran into this issue with my extension. I ended up removing the Bullets icon until I can define the order.

@jrieken

This comment has been minimized.

Member

jrieken commented Nov 17, 2016

There is way to define the order and I am surprised we haven't properly documented that... What you can do is adding an order to the group-attribute like so group: name@number. In your case

{
                    "command": "md-shortcut.toggleBold",
                    "when": "editorLangId == 'markdown'",
                    "group": "2_markdown_1@1"
 }

@jrieken jrieken closed this Nov 17, 2016

@jrieken

This comment has been minimized.

Member

jrieken commented Nov 17, 2016

I'll make sure to update the doc for this

@mdickin

This comment has been minimized.

mdickin commented Nov 17, 2016

Great, thank you so much!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.