New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry not being disabled #16131

Closed
ghost opened this Issue Nov 28, 2016 · 11 comments

Comments

Projects
None yet
8 participants
@ghost

ghost commented Nov 28, 2016

  • VSCode Version: 1.7.2
  • OS Version: Linux, Windows.

Steps to Reproduce:

  1. Disable Telemetry.

I have disabled telemetry as described in the FAQ. I have set the following properties in the settings:

"telemetry.enableCrashReporter": false,
"telemetry.enableTelemetry": false

Now despite of this, when I log my network traffic (with Wireshark) I can see that Visual Studio Code periodically contacts vortex.data.microsoft.com. This is a known server used for telemetry purposes. I have opted out of the telemetry and information is still sent, why? What information is exchanged?

The FAQ describes:

If you don’t wish to send usage data to Microsoft, you can set the telemetry.enableTelemetry setting to false.

To me this means that no telemetry connections should be made, because I would assume that continuous connections to the server can still easily be used to collect information for product usage tracking even if no actual private data is being collected by the application itself.

@seanmcbreen

This comment has been minimized.

Contributor

seanmcbreen commented Dec 1, 2016

We use our telemetry to help understand how to make the product better – in fact a good example of this right now is some work we are doing to improve performance. So, we appreciate it when users opt to send us telemetry.

That said there are times when people don’t want to do that and you bring up a good point – today we continue to send events stating that a user has opted out and nothing else i.e. no usage data is sent. Here is the test to ensure that is all we send...
https://github.com/Microsoft/vscode/blob/master/src/vs/platform/telemetry/common/telemetryService.ts#L103

But we don’t need to do that and I don’t think it’s what you expect as a user – so we will stop sending anything i.e. even the opt out event 😄 Look for a change there soon.

Thanks for bringing this to our attention and I hope you enjoy working with VS Code.

I'll close the issue for now but please fell free to reopen if this is not sufficient.

Sean McBreen – VS Code Team Member

@seanmcbreen seanmcbreen closed this Dec 1, 2016

@kieferrm kieferrm self-assigned this Dec 2, 2016

@kieferrm kieferrm added the telemetry label Dec 2, 2016

@kieferrm kieferrm added this to the November 2016 milestone Dec 2, 2016

kieferrm added a commit that referenced this issue Dec 2, 2016

@bsr203

This comment has been minimized.

bsr203 commented Feb 22, 2017

Hi,

I used to get offline warning, with a stack that it cannot reach vortex.data.microsoft.com. Now, I disabled telemetry through the setting

"telemetry.enableCrashReporter": false,
"telemetry.enableTelemetry": false

after the restart, within 20 seconds, I get the same warning, but a different stack. It doesn't have any log on contacting vortex.data.microsoft.com, but


workbench.main.js:100 The Internet connection appears to be offline.
e.doShow	@	workbench.main.js:100
e.show	@	workbench.main.js:100
(anonymous function)	@	workbench.main.js:141
e.invoke	@	workbench.main.js:30
e.fire	@	workbench.main.js:30
(anonymous function)	@	workbench.main.js:35
y	@	workbench.main.js:32
_progress	@	workbench.main.js:32
y	@	workbench.main.js:32
_progress	@	workbench.main.js:32
t.handlers.(anonymous function)	@	workbench.main.js:35
e.onMessage	@	workbench.main.js:35
(anonymous function)	@	workbench.main.js:35
e.invoke	@	workbench.main.js:30
e.fire	@	workbench.main.js:30
(anonymous function)	@	workbench.main.js:35
e.invoke	@	workbench.main.js:30
e.fire	@	workbench.main.js:30
r	@	workbench.main.js:34
emitTwo	@	events.js:106
emit	@	events.js:191

what else need to avoid detecting offline!!!

Version 1.9.1 (1.9.1)
OSX macOS 10.12.3

@CoeJoder

This comment has been minimized.

CoeJoder commented May 29, 2017

Mid 2017, VS Code still tracking? Sticking with Sublime Text for now.

@CooperSystems

This comment has been minimized.

CooperSystems commented Jun 17, 2017

Yeah I was just about to install this but saw the 'data' thing in the terms and service.

I'm cutting windows out of my life for becoming spyware, was going to give VSCode a chance because it's open source. But not if it's just another foothold into the same old game

@jens1o

This comment has been minimized.

Contributor

jens1o commented Jun 17, 2017

Is that true team? I thought opting out means I'm opt out...

@kieferrm

This comment has been minimized.

Contributor

kieferrm commented Jun 30, 2017

@bsr203 the message you see comes from the autoupdater. It checks if a newer version of VS Code is available by comparing the commit hash. You can disable it by setting update.channel to none in your settings. In case you have extensions installed, you would also see another message caused by the attempt to see if any of the extensions you have installed was updated in the marketplace.

When you have set telemetry.enableCrashReporter and telemetry.enableTelemetry to false no telemetry or crash data is sent to any server.

@bsr203

This comment has been minimized.

bsr203 commented Jul 6, 2017

@kieferrm that make sense. I will try disabling update.channel. thank you.

@delsvr

This comment has been minimized.

delsvr commented Oct 30, 2017

For the record,

Even with:

"telemetry.enableCrashReporter": false,
"telemetry.enableTelemetry": false,
"update.channel": "none"
"extensions.autoUpdate": false

I still see connection attempts by Visual Studio Code to marketplace.visualstudio.com and vortex.data.microsoft.com at startup.

@jens1o

This comment has been minimized.

Contributor

jens1o commented Oct 30, 2017

:(

That's not I'm expecting, although the first url requested is kind of valid, since you only want to disable automatic update, which means that Code is still searching for them.

@seanmcbreen

This comment has been minimized.

Contributor

seanmcbreen commented Nov 15, 2017

Hi,

I saw a comment re: this in twitter right now - so wanted to do a quick update...

I'm pretty sure we [VS Code Core] are doing the right thing here and we would love any pointers (all code is OSS).

To be very clear we want to do the right thing (hence my prior comments) and we think we have no gaps.

At the same time there is a chance an extensions send telemetry and that could be the issue here (we are also working hard to ensure any extension created by our team, other teams and others in general do the right ting). But we don't control all of their code - or the world :)

Net, net - if there is a gap help us find it - we don't think we have one but if we do we will close it.
Sean

@jens1o

This comment has been minimized.

Contributor

jens1o commented Nov 15, 2017

@seanmcbreen We're not talking about that telemetry is bad, but instead, we think that opting out, means, that we do not send ANY analytic. I don't care about your analytic, and you need to accept that, so I only want communication to the Microsoft servers when it is needed(e.g. installing extensions or looking for updates). I do not want to send any further signals.

(Hoping that anyone responds to this)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.