New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve view state for untitled files between restarts #16588

Closed
jrieken opened this Issue Dec 6, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@jrieken
Member

jrieken commented Dec 6, 2016

re #16544

  • have an untitled file, select a word on line 13
  • exit, restart
  • 馃悰 the cursor isn't preserved and not at 1,1

dec-06-2016 10-48-45

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Dec 6, 2016

Member

There is actually no view-state preserved for untitled files because we never had untitled files surviving a restart.

Member

bpasero commented Dec 6, 2016

There is actually no view-state preserved for untitled files because we never had untitled files surviving a restart.

@bpasero bpasero added the hot-exit label Dec 6, 2016

@bpasero bpasero changed the title from cursor state is lost to Preserve view state for untitled files between restarts Dec 7, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Dec 7, 2016

Member

I wanna check if this is low hanging for November, otherwise I will push it out.

Member

bpasero commented Dec 7, 2016

I wanna check if this is low hanging for November, otherwise I will push it out.

@bpasero bpasero self-assigned this Dec 7, 2016

@bpasero bpasero added this to the November 2016 milestone Dec 7, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Dec 8, 2016

Member

Will do in January, it is just a matter of persisting our untitled view state that we already track in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/stringEditor.ts#L36

Member

bpasero commented Dec 8, 2016

Will do in January, it is just a matter of persisting our untitled view state that we already track in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/stringEditor.ts#L36

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Dec 13, 2016

Member

The view state of untitled editors should now preserve and restore after restart with hot exit enabled. This currently only works when having a folder opened. For empty workspaces we still need to tackle #207

Member

bpasero commented Dec 13, 2016

The view state of untitled editors should now preserve and restore after restart with hot exit enabled. This currently only works when having a folder opened. For empty workspaces we still need to tackle #207

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Dec 13, 2016

Member

Awesome 馃槃

Member

Tyriar commented Dec 13, 2016

Awesome 馃槃

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Jan 23, 2017

Member
  • To verify:
    The view state of untitled editors should now preserve and restore after restart with hot exit enabled. This currently only works when having a folder opened.
Member

bpasero commented Jan 23, 2017

  • To verify:
    The view state of untitled editors should now preserve and restore after restart with hot exit enabled. This currently only works when having a folder opened.

@jrieken jrieken added the verified label Jan 24, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.