Preserve view state for untitled files between restarts #16588

Closed
jrieken opened this Issue Dec 6, 2016 · 6 comments

Projects

None yet

3 participants

@jrieken
Member
jrieken commented Dec 6, 2016

re #16544

  • have an untitled file, select a word on line 13
  • exit, restart
  • 🐛 the cursor isn't preserved and not at 1,1

dec-06-2016 10-48-45

@Tyriar Tyriar was assigned by jrieken Dec 6, 2016
@bpasero
Member
bpasero commented Dec 6, 2016

There is actually no view-state preserved for untitled files because we never had untitled files surviving a restart.

@bpasero bpasero added the hot-exit label Dec 6, 2016
@bpasero bpasero changed the title from cursor state is lost to Preserve view state for untitled files between restarts Dec 7, 2016
@bpasero
Member
bpasero commented Dec 7, 2016

I wanna check if this is low hanging for November, otherwise I will push it out.

@bpasero bpasero self-assigned this Dec 7, 2016
@bpasero bpasero added this to the November 2016 milestone Dec 7, 2016
@bpasero
Member
bpasero commented Dec 8, 2016

Will do in January, it is just a matter of persisting our untitled view state that we already track in https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/stringEditor.ts#L36

@bpasero bpasero modified the milestone: January 2017, November 2016 Dec 8, 2016
@Tyriar Tyriar was unassigned by bpasero Dec 8, 2016
@bpasero bpasero closed this in d93b857 Dec 13, 2016
@bpasero
Member
bpasero commented Dec 13, 2016

The view state of untitled editors should now preserve and restore after restart with hot exit enabled. This currently only works when having a folder opened. For empty workspaces we still need to tackle #207

@Tyriar
Member
Tyriar commented Dec 13, 2016

Awesome 😄

@bpasero
Member
bpasero commented Jan 23, 2017
  • To verify:
    The view state of untitled editors should now preserve and restore after restart with hot exit enabled. This currently only works when having a folder opened.
@jrieken jrieken added the verified label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment