New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed git commits do not work without an agent #17014

Closed
davidobrien1985 opened this Issue Dec 10, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@davidobrien1985

davidobrien1985 commented Dec 10, 2016

  • VSCode Version: 1.7.2
  • OS Version: Windows 10, 14986

Configured git to sign commits. In order to sign a commit I now need to add a new parameter to my commit command:
git -S -m 'commit message'

It will then prompt me to enter my password for the private key. From vscode when trying to commit my changes I see the following error message in the git output:

git commit --quiet --allow-empty-message --file -
gpg: cannot open tty `no tty': No such file or directory
error: gpg failed to sign the data
fatal: failed to write commit object
git config --get-all user.name
git config --get-all user.email

I guess vscode should allow me to create signed commits and also prompt me for my password.

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Dec 12, 2016

Member

Please check suggestion in #5065 (comment)

Member

joaomoreno commented Dec 12, 2016

Please check suggestion in #5065 (comment)

@davidobrien1985

This comment has been minimized.

Show comment
Hide comment
@davidobrien1985

davidobrien1985 Dec 15, 2016

@joaomoreno no, that didn't help.

git commit --quiet --allow-empty-message --file -
gpg: Sorry, no terminal at all requested - can't get input
error: gpg failed to sign the data
fatal: failed to write commit object

This git commit here should know how to ask for the key's password and also add the -S parameter to the command.
Committing on the command line works fine, it's just vscode.

davidobrien1985 commented Dec 15, 2016

@joaomoreno no, that didn't help.

git commit --quiet --allow-empty-message --file -
gpg: Sorry, no terminal at all requested - can't get input
error: gpg failed to sign the data
fatal: failed to write commit object

This git commit here should know how to ask for the key's password and also add the -S parameter to the command.
Committing on the command line works fine, it's just vscode.

@joaomoreno joaomoreno changed the title from Signed git commits do not work to Signed git commits do not work without an agent Dec 15, 2016

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Dec 15, 2016

Member

The comment mentions the fact that you should be using an agent. Without an agent we have no support for this. I've renamed the issue accordingly, but strongly suggest for you to give an agent a try.

Member

joaomoreno commented Dec 15, 2016

The comment mentions the fact that you should be using an agent. Without an agent we have no support for this. I've renamed the issue accordingly, but strongly suggest for you to give an agent a try.

@joaomoreno joaomoreno added bug git and removed needs more info labels Dec 15, 2016

@davidobrien1985

This comment has been minimized.

Show comment
Hide comment
@davidobrien1985

davidobrien1985 Dec 16, 2016

What's an agent in this context?

davidobrien1985 commented Dec 16, 2016

What's an agent in this context?

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno
Member

joaomoreno commented Apr 25, 2017

@joaomoreno joaomoreno closed this Apr 25, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.