Search does not work in UTF-16 LE encoded files #17408

Closed
garfieldbanks opened this Issue Dec 16, 2016 · 3 comments

Projects

None yet

6 participants

@garfieldbanks
  • VSCode Version: 1.8.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Create and open a test_folder in VSCode.
    image

  2. Add an XML file encoded in UTF-16 LE.
    image

  3. Add a javascript file encoded in UTF-8.
    image

  4. Make sure both files are closed. Then search for text that can be found in both files. Note that only the javascript file is actually listed in the results.
    image

Note: The XML file encoded in UTF-16 LE is found only if it is currently open in VSCode.

@bpasero
Member
bpasero commented Dec 16, 2016

@garfieldbanks I assume the file contains a UTF-16 LE BOM?

@garfieldbanks
garfieldbanks commented Dec 16, 2016 edited

Wow. That was fast.

I don't know. I just used VSCode to reopen an old file with a new encoding, and then I put in the text with the tag.

@bpasero
Member
bpasero commented Dec 16, 2016 edited

I can reproduce after saving a file within VS Code in UTF-16 LE. Also reproduces with VS Code 1.7.

@sandy081 sandy081 was assigned by bpasero Dec 16, 2016
@bpasero bpasero changed the title from XML files encoded in UTF-16 LE are not searchable in find in folder to Regression: search no longer finds in UTF-16 encoded files Dec 16, 2016
@bpasero bpasero changed the title from Regression: search no longer finds in UTF-16 encoded files to Search does not work in UTF-16 LE encoded files Dec 17, 2016
@bpasero bpasero assigned bpasero and unassigned roblourens, chrmarti, and sandy081 Dec 17, 2016
@bpasero bpasero added this to the January 2017 milestone Dec 17, 2016
@bpasero bpasero added the search label Dec 17, 2016
@bpasero bpasero closed this in 00d483b Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment