Possible to save file multiple times leads to race condition #18037

Closed
bpasero opened this Issue Jan 3, 2017 · 1 comment

Projects

None yet

2 participants

@bpasero
Member
bpasero commented Jan 3, 2017

When auto save is disabled and you work against a slow network share where save takes longer, it is possible to save a file multiple times with different contents leading to bad race conditions where you sporadically see warnings about the contents on disk being newer.

Part of #13665

@bpasero bpasero self-assigned this Jan 3, 2017
@bpasero bpasero added this to the January 2017 milestone Jan 3, 2017
@bpasero bpasero closed this in #18041 Jan 4, 2017
@bpasero
Member
bpasero commented Jan 4, 2017

To verify:

  • connect to a super slow network share (all our internal shares are a good candidate for this)
  • disable auto save
  • edit a file and save
    => this should take quite some time
  • edit a file and save, then continue editing and save
    => basically try to cause many saves (you need to cause changes, otherwise the save request is ignored)

You should never see a save error and the save should eventually complete.

@kieferrm kieferrm added the verified label Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment