Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlebars block expressions are not highlighted anymore #18451

Closed
t-sauer opened this issue Jan 12, 2017 · 5 comments
Closed

Handlebars block expressions are not highlighted anymore #18451

t-sauer opened this issue Jan 12, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues languages-basic Basic language support issues verified Verification succeeded
Milestone

Comments

@t-sauer
Copy link

t-sauer commented Jan 12, 2017

  • VSCode Version: Code - Insiders 1.9.0-insider (ed5a9f2, 2017-01-12T07:05:52.808Z)
  • OS Version: Darwin x64 15.6.0

Steps to Reproduce:

  1. Create a new Handlebars file
  2. Add the following content:
{{#foo}}
  <h1>Test</h1>
{{/foo}}

In the current stable version (1.8.1) the Handlebars expression is highlighted correctly:
screen shot 2017-01-12 at 14 37 18

In the current insider version the Handlebars expression is not highlighted at all:
screen shot 2017-01-12 at 14 40 09

@mjbvz mjbvz added html HTML support issues languages-basic Basic language support issues labels Jan 12, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Jan 12, 2017

@aeschli I confirmed this difference. Not sure if it is expected or if the grammar has been updated recently. Can you please take a look?

@aeschli
Copy link
Contributor

aeschli commented Jan 13, 2017

The grammar stayed the same, but we fixed the way that themes rules are applied to scopes (see #3008).
I verified that the new way of matching is correct. Before it was rather random that {{ .. }} were mapped to functions.

@aeschli
Copy link
Contributor

aeschli commented Jan 19, 2017

Closing as it's the expected behaviour. The default color themes render brackets and operators always with the standard foreground color.

@aeschli aeschli closed this as completed Jan 19, 2017
@t-sauer
Copy link
Author

t-sauer commented Jan 20, 2017

The default color themes render brackets and operators always with the standard foreground color.

Why are non-block operators highlighted then?

screen shot 2017-01-20 at 18 52 34

@aeschli
Copy link
Contributor

aeschli commented Jan 23, 2017

The handlebar grammar gives block expressions the same color as the brackets.
It gives it the support.constant scope which we don't color in the default themes.

I files daaain/Handlebars#94 to give the block expressions a separate color.

I pushed a fix for our themes.

@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Jan 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug html HTML support issues languages-basic Basic language support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants