Upgrade from 1.9.0 turns on minimap in user settings #21665

Closed
rnemec opened this Issue Mar 1, 2017 · 18 comments

Comments

Projects
None yet
9 participants
@rnemec

rnemec commented Mar 1, 2017

  • VSCode Version: 1.10.0
  • OS Version: 10.11.6

Steps to Reproduce:

  1. Upgraded
  2. See minimap
  3. Don't like minimap
  4. Open settings - enabled = false by default
  5. Wonder
  6. Copy setting to user settings and set again to false
  7. CANNOT GET RID of that minimap. SAM-I-AM - I do not like green eggs and ham.
@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 1, 2017

Please, let me know what other information I can provide. I cannot believe that this bug is not yet logged - it must be something unusual in my setup...

rnemec commented Mar 1, 2017

Please, let me know what other information I can provide. I cannot believe that this bug is not yet logged - it must be something unusual in my setup...

@jordanmkasla2009

This comment has been minimized.

Show comment
Hide comment
@jordanmkasla2009

jordanmkasla2009 Mar 2, 2017

Contributor

I can't reproduce this. What OS / Extensions / User Settings are you using?

Contributor

jordanmkasla2009 commented Mar 2, 2017

I can't reproduce this. What OS / Extensions / User Settings are you using?

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

OS = Mac OS 10.11.6
and several extensions (although WHY would they break the mini-thing?) Is there an easy way to dump some useful info for you? I assume this must be something local here since nobody else is complaining...

rnemec commented Mar 2, 2017

OS = Mac OS 10.11.6
and several extensions (although WHY would they break the mini-thing?) Is there an easy way to dump some useful info for you? I assume this must be something local here since nobody else is complaining...

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

Mystery solved!

After the upgrade, for some reason the workspace settings had minimap.enable set to "true". I didn't put that in there, but it got there somehow during the upgrade.
I apologize, I didn't look at the workspace settings because I usually only set the user settings, not workspace.

rnemec commented Mar 2, 2017

Mystery solved!

After the upgrade, for some reason the workspace settings had minimap.enable set to "true". I didn't put that in there, but it got there somehow during the upgrade.
I apologize, I didn't look at the workspace settings because I usually only set the user settings, not workspace.

@rnemec rnemec closed this Mar 2, 2017

@cjsaylor

This comment has been minimized.

Show comment
Hide comment
@cjsaylor

cjsaylor Mar 2, 2017

@rnemec I had the same thing happen as well. Seems to be some sort of bug with the upgrade from 1.09 to 1.10.

cjsaylor commented Mar 2, 2017

@rnemec I had the same thing happen as well. Seems to be some sort of bug with the upgrade from 1.09 to 1.10.

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

Reopening as upgrade bug.

rnemec commented Mar 2, 2017

Reopening as upgrade bug.

@rnemec rnemec reopened this Mar 2, 2017

@rnemec rnemec changed the title from Cannot turn off the minimap to Upgrade turns on minimap in user settings Mar 2, 2017

@rnemec rnemec changed the title from Upgrade turns on minimap in user settings to Upgrade from 1.9.0 turns on minimap in user settings Mar 2, 2017

@fengcen

This comment has been minimized.

Show comment
Hide comment
@fengcen

fengcen Mar 2, 2017

I found that this extension "Sublime Text Keymap" will automatically create .vscode folder and settings.json

fengcen commented Mar 2, 2017

I found that this extension "Sublime Text Keymap" will automatically create .vscode folder and settings.json

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

I don't have "Sublime Text Keymap" extension. And I already had the settings.json in the workspace's .vscode, just not used much.
Is it possible that the upgrade would just add the minimap.enabled=true if there is settings.json in workspace's .vscode?

rnemec commented Mar 2, 2017

I don't have "Sublime Text Keymap" extension. And I already had the settings.json in the workspace's .vscode, just not used much.
Is it possible that the upgrade would just add the minimap.enabled=true if there is settings.json in workspace's .vscode?

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

I just upgraded to 1.10.1 and guess what - the upgrade added the minimap.enabled=true to my workspace settings again.

rnemec commented Mar 2, 2017

I just upgraded to 1.10.1 and guess what - the upgrade added the minimap.enabled=true to my workspace settings again.

@fengcen

This comment has been minimized.

Show comment
Hide comment
@fengcen

fengcen Mar 2, 2017

I only know that "Sublime Text Keymap" will automatically enable minimap and create workspace setting.

It works fine for me after I disable this extension.

fengcen commented Mar 2, 2017

I only know that "Sublime Text Keymap" will automatically enable minimap and create workspace setting.

It works fine for me after I disable this extension.

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

Qiu, you are correct!
Keymap plugins.
I am using "Atom Keymap" and whenever the workspace is reloaded, it turns on the minimap. When the plugin is disabled, it behaves OK.

rnemec commented Mar 2, 2017

Qiu, you are correct!
Keymap plugins.
I am using "Atom Keymap" and whenever the workspace is reloaded, it turns on the minimap. When the plugin is disabled, it behaves OK.

@gluons

This comment has been minimized.

Show comment
Hide comment
@gluons

gluons Mar 2, 2017

For me, .vscode folder always be automatically created every time I open VSCode. That's really annoying.
I'm using Atom Keymap too.

gluons commented Mar 2, 2017

For me, .vscode folder always be automatically created every time I open VSCode. That's really annoying.
I'm using Atom Keymap too.

@rnemec

This comment has been minimized.

Show comment
Hide comment
@rnemec

rnemec Mar 2, 2017

A workaround for all who cannot wait for the Atom Keymap plugin to get fixed (not sure about other plugins):

  1. go to file ~/.vscode/extensions/ms-vscode.atom-keybindings-2.0.0/out/src/extension.js
  2. comment out the body of the activate method
  3. enjoy

Plus or minus some version number, and possibly something similar may work for the other plugin.

rnemec commented Mar 2, 2017

A workaround for all who cannot wait for the Atom Keymap plugin to get fixed (not sure about other plugins):

  1. go to file ~/.vscode/extensions/ms-vscode.atom-keybindings-2.0.0/out/src/extension.js
  2. comment out the body of the activate method
  3. enjoy

Plus or minus some version number, and possibly something similar may work for the other plugin.

@gluons gluons referenced this issue in Microsoft/vscode-atom-keybindings Mar 2, 2017

Closed

This extension forces minimap each time workspace reloads #29

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Mar 2, 2017

Member

We are looking into publishing a fixed version of this extension.

Member

alexandrudima commented Mar 2, 2017

We are looking into publishing a fixed version of this extension.

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Mar 2, 2017

Member

We published a new version of this extension that no longer writes to workspace settings.

Member

alexandrudima commented Mar 2, 2017

We published a new version of this extension that no longer writes to workspace settings.

@egamma

This comment has been minimized.

Show comment
Hide comment
@egamma

egamma Mar 2, 2017

Member

Moving the issue to the sublime extension repository.

Member

egamma commented Mar 2, 2017

Moving the issue to the sublime extension repository.

@egamma egamma referenced this issue in Microsoft/vscode-sublime-keybindings Mar 2, 2017

Closed

Upgrade from 1.9.0 turns on minimap in user settings #48

@egamma

This comment has been minimized.

Show comment
Hide comment
Member

egamma commented Mar 2, 2017

This issue was moved to Microsoft/vscode-sublime-keybindings#48

@egamma egamma closed this Mar 2, 2017

@marvambi

This comment has been minimized.

Show comment
Hide comment
@marvambi

marvambi Jun 29, 2017

Hello folks,
I'm currently using VS Code version: 1.13.1
Disabling the minimap is just changing your settings as follows:
Step 1. Go to Your "File" menu and mouse over Preferences
Step 2. Select or Click on Settings from the sub menu that appears to the right of Preferences
Step 3. Type minimap in the Search Settings Box that appears
Step 4. From the list of minimap settings that appear, click on the edit icon (pencil) that appear beside it
Step 5. Select false to disable the minimap or true to show it.

You can also achieve this using the following Keyboard Combination:
Step 1. Press Ctrl + Comma
Step 2. Type minimap in the Search Settings Box that appears
Step 3. From the list of minimap settings that appear, click on the edit icon (pencil) that appear beside it
Step 4. Select false to disable the minimap or true to show it.

But I think it will be nice to have it toggle on/off the old way.

Hello folks,
I'm currently using VS Code version: 1.13.1
Disabling the minimap is just changing your settings as follows:
Step 1. Go to Your "File" menu and mouse over Preferences
Step 2. Select or Click on Settings from the sub menu that appears to the right of Preferences
Step 3. Type minimap in the Search Settings Box that appears
Step 4. From the list of minimap settings that appear, click on the edit icon (pencil) that appear beside it
Step 5. Select false to disable the minimap or true to show it.

You can also achieve this using the following Keyboard Combination:
Step 1. Press Ctrl + Comma
Step 2. Type minimap in the Search Settings Box that appears
Step 3. From the list of minimap settings that appear, click on the edit icon (pencil) that appear beside it
Step 4. Select false to disable the minimap or true to show it.

But I think it will be nice to have it toggle on/off the old way.

@Microsoft Microsoft locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.