New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cannot switch tabs by touch gestures in Surface Pro 3. #22523

Closed
scientist2009 opened this Issue Mar 13, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@scientist2009

scientist2009 commented Mar 13, 2017

  • VSCode Version: Code 1.8.0 (3874693, 2016-12-13T17:45:32.595Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
code-gnu-global austin 0.2.1
cpptools ms-vscode 0.10.2
vs-keybindings ms-vscode 0.1.3

Steps to Reproduce:

1.Use the vscode in a Surface Pro 3.
2.Open two source file with vscode.
3.Select a tab between the two source file, and touch it. I cannot switch tab by touch gestures. Please fix it.

@bpasero bpasero added this to the Backlog milestone Mar 13, 2017

@bpasero bpasero added the workbench label Apr 7, 2017

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Apr 10, 2017

Member

Todays VS Code insider build comes with Electron 1.6.x, would be interesting to hear if this update solves this issue for anyone: http://code.visualstudio.com/Download#insiders

Member

bpasero commented Apr 10, 2017

Todays VS Code insider build comes with Electron 1.6.x, would be interesting to hear if this update solves this issue for anyone: http://code.visualstudio.com/Download#insiders

@bpasero bpasero removed the bug label Apr 10, 2017

bpasero added a commit that referenced this issue Oct 23, 2017

@bpasero bpasero added bug and removed electron upstream labels Oct 23, 2017

@bpasero bpasero modified the milestones: Backlog, October 2017 Oct 23, 2017

@bpasero bpasero closed this Oct 23, 2017

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Oct 26, 2017

Member

Verification:

  • tabs can be opened via touch
  • tab context menu can be triggered via touch long press
  • tabs can be scrolled (if there is a scrollbar) using touch gesture
Member

bpasero commented Oct 26, 2017

Verification:

  • tabs can be opened via touch
  • tab context menu can be triggered via touch long press
  • tabs can be scrolled (if there is a scrollbar) using touch gesture
@roblourens

This comment has been minimized.

Show comment
Hide comment
@roblourens

roblourens Nov 3, 2017

Member

Trying on a surface book, all of it works much better than 1.17.

But when showTabs disabled, it's almost impossible to switch tabs by touch. I can do it if I touch just right.

Member

roblourens commented Nov 3, 2017

Trying on a surface book, all of it works much better than 1.17.

But when showTabs disabled, it's almost impossible to switch tabs by touch. I can do it if I touch just right.

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Nov 5, 2017

Member

@roblourens extracted that into #37671

Member

bpasero commented Nov 5, 2017

@roblourens extracted that into #37671

@bpasero bpasero closed this Nov 5, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 20, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.