Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken icons when open project from terminal #26270

Closed
redVi opened this issue May 9, 2017 · 8 comments
Closed

Broken icons when open project from terminal #26270

redVi opened this issue May 9, 2017 · 8 comments
Assignees
Labels
candidate Issue identified as probable candidate for fixing in the next release *duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority
Milestone

Comments

@redVi
Copy link

redVi commented May 9, 2017

  • VSCode Version: 1.12.1
  • OS Version: macOS Sierra

Steps to Reproduce:

  1. Open terminal an run code path_to_folder

console

  1. The icons look awful (after update to 1.12.1)

code

@jenswegar
Copy link

I'm seeing the same thing. Opening from terminal with code /path/to/project draws all icons in the UI as strange artifacts. Opening the same project by first opening vscode, then using file->open recent draws the UI as expected.

macOS sierra 10.12.4
vscode: 1.12.1

@hannupekka
Copy link

Same here.

OSX El Capitan 10.11.6
VSCode 1.12.1

@joaomoreno joaomoreno removed their assignment May 9, 2017
@bpasero bpasero added candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority labels May 9, 2017
@bpasero bpasero added this to the May 2017 milestone May 9, 2017
@bpasero
Copy link
Member

bpasero commented May 9, 2017

This is #24820 but I wonder why my workaround is not working as expected in main.js

@redVi @jenswegar @hannupekka can you send me the contents of your shell environment? You can quickly get there by running process.env from the console when developer tools are open (from the help menu):

image

@redVi
Copy link
Author

redVi commented May 9, 2017

@bpasero yes, this is the same reason. I removed locale settings export LC_CTYPE and export LC_ALL and now the artifacts are gone.

@bpasero
Copy link
Member

bpasero commented May 9, 2017

@redVi and so what are the values you have for LC_CTYPE and LC_ALL?

@redVi
Copy link
Author

redVi commented May 9, 2017

@bpasero

export LC_CTYPE="ru_RU.UTF-8"
export LC_ALL="ru_RU.UTF-8"

@hannupekka
Copy link

@bpasero from my process.env output:

LC_ALL: "fi_FI.UTF-8"
LC_COLLATE: "fi_FI.UTF-8"
LC_CTYPE: "fi_FI.UTF-8"
LC_MESSAGES: "fi_FI.UTF-8"
LC_MONETARY: "fi_FI.UTF-8"
LC_NUMERIC: "C"
LC_TIME: "fi_FI.UTF-8"

@bpasero
Copy link
Member

bpasero commented May 9, 2017

Closing as duplicate of #24820. It looks like having an environment variable LC_ALL with certain languages is enough to trigger this issue. In #24820 I was pushing a workaround when LC_NUMERIC is defined but this does not seem to be enough.

There are three options for people hitting this:

@bpasero bpasero closed this as completed May 9, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release *duplicate Issue identified as a duplicate of another issue(s) important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

5 participants