New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panel position configurable #2806

Closed
indiejames opened this Issue Feb 9, 2016 · 124 comments

Comments

@indiejames

indiejames commented Feb 9, 2016

I just upgraded to VS Code 0.10.8 and I see that the debug console is now at the bottom of the window. I can see how some people might prefer this, but I actually preferred having it on the right side. The position (right/bottom) should be configurable in settings.

@isidorn isidorn added this to the Backlog milestone Feb 9, 2016

@TheLevenCreations

This comment has been minimized.

Show comment
Hide comment
@TheLevenCreations

TheLevenCreations commented Feb 9, 2016

+1

@felixfbecker

This comment has been minimized.

Show comment
Hide comment
@felixfbecker

felixfbecker Feb 21, 2016

Contributor

I would prefer a button right at the window in addition to a default setting. Also, previously you could have the debug console take 100% of the space by closing other windows. Now, this is not possible anymore. It would be better if all windows shared the same behaviour, so every window (file, debug console or task output) could be docked vertically, horizontally or maximized to 100%.

Contributor

felixfbecker commented Feb 21, 2016

I would prefer a button right at the window in addition to a default setting. Also, previously you could have the debug console take 100% of the space by closing other windows. Now, this is not possible anymore. It would be better if all windows shared the same behaviour, so every window (file, debug console or task output) could be docked vertically, horizontally or maximized to 100%.

@bgashler1

This comment has been minimized.

Show comment
Hide comment
@bgashler1

bgashler1 Mar 2, 2016

Contributor

@felixfbecker thanks for your feedback!

We made the console horizontal so that long output could be seen without being clipped at the end. Since you prefer the vertical console, I'm interested in how you made the vertical console work when the output was wider than could be displayed. Could you share what you did in situations like that?

When we made the debug console horizontal we wanted to make sure it would not be confused with same functionality of a text editor that has focus—thus avoiding making users think that clicking on a file in the Explorer viewlet will focused on the console can replace the console with the open file. This was a problem previously—the vertical debug console was often replaced with a file when opened because it had focus.

We are exploring making it possible to split text editors horizontally and vertically, as well as allowing the console to be either horizontally or vertically. We also want to keep a distinction between the console and editors to avoid people thinking that it can be replaced with a text editor.

Does this sound like it will resolve your concerns?

Contributor

bgashler1 commented Mar 2, 2016

@felixfbecker thanks for your feedback!

We made the console horizontal so that long output could be seen without being clipped at the end. Since you prefer the vertical console, I'm interested in how you made the vertical console work when the output was wider than could be displayed. Could you share what you did in situations like that?

When we made the debug console horizontal we wanted to make sure it would not be confused with same functionality of a text editor that has focus—thus avoiding making users think that clicking on a file in the Explorer viewlet will focused on the console can replace the console with the open file. This was a problem previously—the vertical debug console was often replaced with a file when opened because it had focus.

We are exploring making it possible to split text editors horizontally and vertically, as well as allowing the console to be either horizontally or vertically. We also want to keep a distinction between the console and editors to avoid people thinking that it can be replaced with a text editor.

Does this sound like it will resolve your concerns?

@felixfbecker

This comment has been minimized.

Show comment
Hide comment
@felixfbecker

felixfbecker Mar 2, 2016

Contributor

@bgashler1

TL;DR highlight the currently focused window better, make all windows behave the same

I'm a bit on the fence wether I prefer vertical or horizontal. But many use 16:9 monitors, and I certainly notice that editing files with the horizontal console open is not fun because there is not enough space for the editor. I catch myself closing the console as soon as I scroll through some file while debugging so my eyes can scan it more easily.

We made the console horizontal so that long output could be seen without being clipped at the end. Since you prefer the vertical console, I'm interested in how you made the vertical console work when the output was wider than could be displayed. Could you share what you did in situations like that?

When the console output did not fit, I just resized the window or even closed the open file so I had a full-width debug console. I then went back to the file with Ctrl+Tab. One thing I would like to see is a button in the console to toggle wrapping of long lines, because sometimes it is beneficial (for ultra-long string outputs) and sometimes it is annoying and breaks formatting (for stack traces). Being able to disable wrapping in certain cases would also reduce the need for a horizontal console.

When we made the debug console horizontal we wanted to make sure it would not be confused with same functionality of a text editor that has focus—thus avoiding making users think that clicking on a file in the Explorer viewlet will focused on the console can replace the console with the open file. This was a problem previously—the vertical debug console was often replaced with a file when opened because it had focus.

Yes, that was sometimes confusing, but I think the reason was that there are not many visual indicators what window has focus. In the January release there was a lot of work for accessibility. For example, the debug section now has slick blue outlines that indicate when a panel is focused:

screenshot 22

Maybe you could add a similar outline around the current window so it is clear what window gets replaced when a file is opened?

We are exploring making it possible to split text editors horizontally and vertically, as well as allowing the console to be either horizontally or vertically. We also want to keep a distinction between the console and editors to avoid people thinking that it can be replaced with a text editor.

Im definitely +1 for "universal" window management, where every window can get docked vertically or horizontally - as a bonus I would even like to see undocking of windows to drag the console on a second monitor. But I have the feeling that this distinction would get messy. How will you make that distinction visible if the windows have the same features and buttons? I think all windows should behave the same.

Contributor

felixfbecker commented Mar 2, 2016

@bgashler1

TL;DR highlight the currently focused window better, make all windows behave the same

I'm a bit on the fence wether I prefer vertical or horizontal. But many use 16:9 monitors, and I certainly notice that editing files with the horizontal console open is not fun because there is not enough space for the editor. I catch myself closing the console as soon as I scroll through some file while debugging so my eyes can scan it more easily.

We made the console horizontal so that long output could be seen without being clipped at the end. Since you prefer the vertical console, I'm interested in how you made the vertical console work when the output was wider than could be displayed. Could you share what you did in situations like that?

When the console output did not fit, I just resized the window or even closed the open file so I had a full-width debug console. I then went back to the file with Ctrl+Tab. One thing I would like to see is a button in the console to toggle wrapping of long lines, because sometimes it is beneficial (for ultra-long string outputs) and sometimes it is annoying and breaks formatting (for stack traces). Being able to disable wrapping in certain cases would also reduce the need for a horizontal console.

When we made the debug console horizontal we wanted to make sure it would not be confused with same functionality of a text editor that has focus—thus avoiding making users think that clicking on a file in the Explorer viewlet will focused on the console can replace the console with the open file. This was a problem previously—the vertical debug console was often replaced with a file when opened because it had focus.

Yes, that was sometimes confusing, but I think the reason was that there are not many visual indicators what window has focus. In the January release there was a lot of work for accessibility. For example, the debug section now has slick blue outlines that indicate when a panel is focused:

screenshot 22

Maybe you could add a similar outline around the current window so it is clear what window gets replaced when a file is opened?

We are exploring making it possible to split text editors horizontally and vertically, as well as allowing the console to be either horizontally or vertically. We also want to keep a distinction between the console and editors to avoid people thinking that it can be replaced with a text editor.

Im definitely +1 for "universal" window management, where every window can get docked vertically or horizontally - as a bonus I would even like to see undocking of windows to drag the console on a second monitor. But I have the feeling that this distinction would get messy. How will you make that distinction visible if the windows have the same features and buttons? I think all windows should behave the same.

@bgashler1

This comment has been minimized.

Show comment
Hide comment
@bgashler1

bgashler1 Mar 3, 2016

Contributor

@felixfbecker thanks so much for sharing! This is great feedback. I'm going to discuss it with the team. We really want to improve this experience.

Contributor

bgashler1 commented Mar 3, 2016

@felixfbecker thanks so much for sharing! This is great feedback. I'm going to discuss it with the team. We really want to improve this experience.

@AnthonyWC

This comment has been minimized.

Show comment
Hide comment
@AnthonyWC

AnthonyWC Jul 9, 2016

+1 This is really a basic and needed feature that would improve UX for everyone; even a maximize button would be better than nothing.

AnthonyWC commented Jul 9, 2016

+1 This is really a basic and needed feature that would improve UX for everyone; even a maximize button would be better than nothing.

@Tyriar Tyriar referenced this issue Jul 14, 2016

Closed

Improve integrated terminal #8936

4 of 6 tasks complete
@kontomondo

This comment has been minimized.

Show comment
Hide comment
@kontomondo

kontomondo Aug 2, 2016

+1 Modern computer screens' ratio of 16:9 means that there's considerably less vertical space, no point in wasting it.

kontomondo commented Aug 2, 2016

+1 Modern computer screens' ratio of 16:9 means that there's considerably less vertical space, no point in wasting it.

@isidorn isidorn removed their assignment Sep 5, 2016

@karai17

This comment has been minimized.

Show comment
Hide comment
@karai17

karai17 Sep 18, 2016

This is definitely a big deal for me. I moved from a vertical 1080p screen to a horizontal 1440p screen and I am very much missing the vertical space I had when using vscode. Being able to reposition the output panel to take up some of that unused horizontal space would make working on a standard 16:9 screen a lot more comfortable.

With my current screen, I would be able to comfortably have 2 text buffers and the output panel open side-by-side-by-side. That would be great!

karai17 commented Sep 18, 2016

This is definitely a big deal for me. I moved from a vertical 1080p screen to a horizontal 1440p screen and I am very much missing the vertical space I had when using vscode. Being able to reposition the output panel to take up some of that unused horizontal space would make working on a standard 16:9 screen a lot more comfortable.

With my current screen, I would be able to comfortably have 2 text buffers and the output panel open side-by-side-by-side. That would be great!

@jims

This comment has been minimized.

Show comment
Hide comment
@jims

jims Sep 26, 2016

Yeah, I really can't use vscode on my 16:9 1080p monitor anymore. Stuff that spans full-width is not very nice on landscape widescreen monitors :(

jims commented Sep 26, 2016

Yeah, I really can't use vscode on my 16:9 1080p monitor anymore. Stuff that spans full-width is not very nice on landscape widescreen monitors :(

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Nov 7, 2016

Member

Adding the integrated terminal label so it's easier for me to find as it's one of the main use cases for this.

Member

Tyriar commented Nov 7, 2016

Adding the integrated terminal label so it's easier for me to find as it's one of the main use cases for this.

@heisian

This comment has been minimized.

Show comment
Hide comment
@heisian

heisian Oct 6, 2017

@AndrewHuffman giving you a thumbs up since most people coming to this thread are here to demand a non-trivial fix and become upset when it's not available.

Instead let's all go here like @ngryman mentioned: #34267
and start working on a solution.

heisian commented Oct 6, 2017

@AndrewHuffman giving you a thumbs up since most people coming to this thread are here to demand a non-trivial fix and become upset when it's not available.

Instead let's all go here like @ngryman mentioned: #34267
and start working on a solution.

@dkumar431

This comment has been minimized.

Show comment
Hide comment
@dkumar431

dkumar431 Oct 7, 2017

+1 for vertical integrated terminal

dkumar431 commented Oct 7, 2017

+1 for vertical integrated terminal

@cookra

This comment has been minimized.

Show comment
Hide comment
@cookra

cookra Oct 9, 2017

+1 for having the option to chose where I want this and any panel, think Adobe's panel system;) Big ask granted

cookra commented Oct 9, 2017

+1 for having the option to chose where I want this and any panel, think Adobe's panel system;) Big ask granted

@alex-osman

This comment has been minimized.

Show comment
Hide comment
@alex-osman

alex-osman Oct 9, 2017

+1 for vertical integrated terminal

alex-osman commented Oct 9, 2017

+1 for vertical integrated terminal

@gabrielbc

This comment has been minimized.

Show comment
Hide comment
@gabrielbc

gabrielbc Oct 10, 2017

the horizontal terminal doesnt bother me that much, but would be great to have a vertical debug console

gabrielbc commented Oct 10, 2017

the horizontal terminal doesnt bother me that much, but would be great to have a vertical debug console

@bhargavrpatel

This comment has been minimized.

Show comment
Hide comment
@bhargavrpatel

bhargavrpatel Oct 16, 2017

@arturosaco @heisian I usually opt to not criticize others. I understand that you do not need this as a vertical terminal. However, its also something others want. This is an open source community. You simply down voting every single request comes off a bit negative.

This is not a fix but a feature request. It is not trivial either. If it was, the issue would not have been so long.

I'd suggest a bit more empathy on your part. Down voting of this implies that you do not want this change as it hinders your workflow. I do not believe this to be a case. Its an option that the fine folks above are requesting.

bhargavrpatel commented Oct 16, 2017

@arturosaco @heisian I usually opt to not criticize others. I understand that you do not need this as a vertical terminal. However, its also something others want. This is an open source community. You simply down voting every single request comes off a bit negative.

This is not a fix but a feature request. It is not trivial either. If it was, the issue would not have been so long.

I'd suggest a bit more empathy on your part. Down voting of this implies that you do not want this change as it hinders your workflow. I do not believe this to be a case. Its an option that the fine folks above are requesting.

@heisian

This comment has been minimized.

Show comment
Hide comment
@heisian

heisian Oct 16, 2017

@bhargavrpatel I would LOVE to have a side-panel Terminal. I would also LOVE to have a bottom-panel search area. I am NOT telling people to fuck off, I'm telling people to stop +1'ing this thread because it results in NO contribution whatsoever to resolving this feature request.

It's common practice to strongly encourage users to contribute rather than just stick a +1 to a thread because (especially at this point when it's obvious many people want this feature) it offers nothing to the discussion.

heisian commented Oct 16, 2017

@bhargavrpatel I would LOVE to have a side-panel Terminal. I would also LOVE to have a bottom-panel search area. I am NOT telling people to fuck off, I'm telling people to stop +1'ing this thread because it results in NO contribution whatsoever to resolving this feature request.

It's common practice to strongly encourage users to contribute rather than just stick a +1 to a thread because (especially at this point when it's obvious many people want this feature) it offers nothing to the discussion.

@clankill3r

This comment has been minimized.

Show comment
Hide comment
@clankill3r

clankill3r Oct 17, 2017

clankill3r commented Oct 17, 2017

@hai5nguy

This comment has been minimized.

Show comment
Hide comment
@hai5nguy

hai5nguy commented Oct 18, 2017

+1

@ngryman

This comment has been minimized.

Show comment
Hide comment
@ngryman

ngryman Oct 18, 2017

I think you should lock this issue and point to the PR 😂

ngryman commented Oct 18, 2017

I think you should lock this issue and point to the PR 😂

@egamma egamma referenced this issue Oct 23, 2017

Closed

Iteration Plan for October 2017 #35875

38 of 40 tasks complete
@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Oct 25, 2017

Contributor

Fixed via #36827
You can try it out in tomorrows vscode inisders https://code.visualstudio.com/insiders/
Or in the next stable release in about two weeks.

Contributor

isidorn commented Oct 25, 2017

Fixed via #36827
You can try it out in tomorrows vscode inisders https://code.visualstudio.com/insiders/
Or in the next stable release in about two weeks.

@isidorn isidorn closed this Oct 25, 2017

@isidorn isidorn modified the milestones: On Deck, October 2017 Oct 25, 2017

@isidorn isidorn added the on-testplan label Oct 25, 2017

@isidorn isidorn referenced this issue Oct 25, 2017

Closed

Test: vertical panel layout #36906

3 of 3 tasks complete
@clankill3r

This comment has been minimized.

Show comment
Hide comment
@clankill3r

clankill3r Oct 26, 2017

Someone please post a screenshot :)

clankill3r commented Oct 26, 2017

Someone please post a screenshot :)

@dkumar431

This comment has been minimized.

Show comment
Hide comment
@dkumar431

dkumar431 commented Oct 26, 2017

screen shot 2017-10-26 at 5 03 47 pm

@cielakm

This comment has been minimized.

Show comment
Hide comment
@cielakm

cielakm Oct 29, 2017

This is great and I was waiting for this option a long time. Great work and great add on I will be definitely switching to code now.
Just a quick question. Is there a plan to add a switch so the terminal would appear on the left not on the right and not to the bottom but to top?

cielakm commented Oct 29, 2017

This is great and I was waiting for this option a long time. Great work and great add on I will be definitely switching to code now.
Just a quick question. Is there a plan to add a switch so the terminal would appear on the left not on the right and not to the bottom but to top?

@mcdermed

This comment has been minimized.

Show comment
Hide comment
@Domer79

This comment has been minimized.

Show comment
Hide comment
@Domer79

Domer79 Nov 9, 2017

terminal_vertical

That is how it should be?

Domer79 commented Nov 9, 2017

terminal_vertical

That is how it should be?

@dwdc529

This comment has been minimized.

Show comment
Hide comment
@dwdc529

dwdc529 commented Nov 9, 2017

@cielakm

This comment has been minimized.

Show comment
Hide comment
@cielakm

cielakm Nov 12, 2017

I have the same issue on the release and insiders.

cielakm commented Nov 12, 2017

I have the same issue on the release and insiders.

@ffiw

This comment has been minimized.

Show comment
Hide comment
@ffiw

ffiw Dec 1, 2017

Thanks, I will test drive it a little to see if I can ditch my current tmux and vim setup.

ffiw commented Dec 1, 2017

Thanks, I will test drive it a little to see if I can ditch my current tmux and vim setup.

@AkashGutha

This comment has been minimized.

Show comment
Hide comment
@AkashGutha

AkashGutha Dec 1, 2017

Contributor

I'm already using it and it's amazing

Contributor

AkashGutha commented Dec 1, 2017

I'm already using it and it's amazing

@rsmolkin

This comment has been minimized.

Show comment
Hide comment
@rsmolkin

rsmolkin Dec 1, 2017

Yes, well done. But it seems on Windows there is no X in the upper right corner to close it, while on a mac there is... Odd.

rsmolkin commented Dec 1, 2017

Yes, well done. But it seems on Windows there is no X in the upper right corner to close it, while on a mac there is... Odd.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 9, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.