New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Shortcut to Skip Preview Using Quick Open #30530

Closed
seesemichaelj opened this Issue Jul 12, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@seesemichaelj
Contributor

seesemichaelj commented Jul 12, 2017

I almost always use Quick Open (Ctrl/Command + P) to open my files. Sometimes I want to open multiple files, but they open in Preview by default when using the Quick Open.

I know that there is a user setting that allows you to disable Preview, but 85% of the time I enjoy the Preview.

This is a feature request to add a keyboard shortcut to open the selected file in Quick Open and skip Preview mode. The default behavior on Enter should still open it in Preview mode.

  • VSCode Version: 1.14.0
  • OS Version: Windows 10/elementary OS

Steps to Reproduce:

  1. Open "Quick Open" view using Ctrl (or Command) + P
  2. Type in a name
  3. Press Enter
  4. Verify that files is open in Preview mode
@Kampfmoehre

This comment has been minimized.

Show comment
Hide comment
@Kampfmoehre

Kampfmoehre Jul 12, 2017

+1 I would also like to see this feature implemented.

Kampfmoehre commented Jul 12, 2017

+1 I would also like to see this feature implemented.

@chrmarti

This comment has been minimized.

Show comment
Hide comment
@chrmarti

chrmarti Jul 12, 2017

Contributor

You could use Keep Editor bound to Ctrl+K Enter (Cmd+K Enter on Mac) on the open editor.

Contributor

chrmarti commented Jul 12, 2017

You could use Keep Editor bound to Ctrl+K Enter (Cmd+K Enter on Mac) on the open editor.

@seesemichaelj

This comment has been minimized.

Show comment
Hide comment
@seesemichaelj

seesemichaelj Jul 12, 2017

Contributor

I'll use that in the meantime while this gets implemented. Thanks for the tip!

Contributor

seesemichaelj commented Jul 12, 2017

I'll use that in the meantime while this gets implemented. Thanks for the tip!

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Jul 12, 2017

Member

Yeah I do agree that quick open is missing a way to open an entry in pinned mode, similar to how double clicking in the explorer will pin a file.

Member

bpasero commented Jul 12, 2017

Yeah I do agree that quick open is missing a way to open an entry in pinned mode, similar to how double clicking in the explorer will pin a file.

@bpasero bpasero added the quick-pick label Jul 12, 2017

@bpasero bpasero removed their assignment Jul 12, 2017

@chrmarti chrmarti removed the new release label Aug 1, 2017

@bpasero bpasero removed the workbench label Nov 16, 2017

@bpasero bpasero changed the title from Feature: Keyboard Shortcut to Skip Preview Using Quick Open to Keyboard Shortcut to Skip Preview Using Quick Open Nov 17, 2017

@bpasero bpasero closed this in 61ce8fd Nov 22, 2017

@bpasero bpasero added this to the November 2017 milestone Nov 22, 2017

@bpasero bpasero self-assigned this Nov 22, 2017

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Nov 22, 2017

Member

Settled on Alt+Enter.

Member

bpasero commented Nov 22, 2017

Settled on Alt+Enter.

@cleidigh

This comment has been minimized.

Show comment
Hide comment
@cleidigh

cleidigh Nov 23, 2017

Collaborator

@bpasero
Great! I've been wanting this command, have had to use 'Space' then Undo as touch.
Any reason not to add to explorer, file search, git?
If you agree I will do an issue and PR.

Collaborator

cleidigh commented Nov 23, 2017

@bpasero
Great! I've been wanting this command, have had to use 'Space' then Undo as touch.
Any reason not to add to explorer, file search, git?
If you agree I will do an issue and PR.

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Nov 24, 2017

Member

@cleidigh let me look into that, it should be done on a layer where every tree benefits from this...

Member

bpasero commented Nov 24, 2017

@cleidigh let me look into that, it should be done on a layer where every tree benefits from this...

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Nov 24, 2017

Member

I extracted #39101 for that purpose.

Member

bpasero commented Nov 24, 2017

I extracted #39101 for that purpose.

@dbaeumer dbaeumer added the verified label Dec 5, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.