Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to theme the entire workbench #3112

Closed
SetTrend opened this issue Feb 18, 2016 · 86 comments
Closed

Support to theme the entire workbench #3112

SetTrend opened this issue Feb 18, 2016 · 86 comments
Assignees
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming themes Color theme issues
Milestone

Comments

@SetTrend
Copy link

Currently, color themes are not getting applied to the toolbar on the left:

code theme

I tend to believe this is not intentional as it inhibits accessibility, e.g. with high-contrast themes.

So I propose to have themes apply to the VS Code toolbar, too.

@SetTrend SetTrend changed the title Apply theme to VS Code toolbar, too Apply color themes to VS Code toolbar, too Feb 18, 2016
@egamma egamma added feature-request Request for new features or functionality workbench labels Feb 18, 2016
@bpasero bpasero changed the title Apply color themes to VS Code toolbar, too Support to theme the entire workbench Feb 29, 2016
@bpasero bpasero added this to the Backlog milestone Feb 29, 2016
@bpasero bpasero removed their assignment Feb 29, 2016
@bpasero bpasero self-assigned this Mar 30, 2016
@akamud
Copy link
Contributor

akamud commented Jun 6, 2016

+1. I get a lot of people asking for this for my theme. I assume a lot of theme developers do.

@MLefebvreICO
Copy link

Can we get some feedback on this ?

@bpasero bpasero removed their assignment Aug 17, 2016
@Kainax
Copy link

Kainax commented Aug 24, 2016

+1 Please add sidebar coloring theme

@clssw1004
Copy link

Very much agree with

@lucsky
Copy link

lucsky commented Sep 10, 2016

+100

@nfantone
Copy link

Currently, themes other than the default tend to look kinda awkward when displayed alongside the toolbar and sidebar. See, for instance, how it can change the general look and feel when using something like VScode Custom CSS extension.

screen shot 2016-09-16 at 11 55 23 am

@be5invis
Copy link
Contributor

+1

1 similar comment
@leaxoy
Copy link

leaxoy commented Sep 24, 2016

+1

@Tyriar
Copy link
Member

Tyriar commented Sep 25, 2016

Themes looks particularly bad when the background is neither particularly dark or light:

image

https://marketplace.visualstudio.com/items?itemName=rebornix.nova

@wprater
Copy link
Contributor

wprater commented Mar 28, 2017

@martinsuchan our theming support is currently limited to what can be done via DOM APIs, but does not cover native elements outside that area (like the menu bar).

@bpasero can we expect support for setting -webkit-font-smooting on each part? e.g. setting a value on the status bar and explorer and another on the editor pane?

@pseudo-su
Copy link

I've switched to insiders so I can test the Solarized Dark theme.

I'm not sure if these are issues with the theme or the theming support but I've tried to find all the ui areas that I think aren't themed yet. Some are pretty minor but hopefully it helps.

Autocomplete box

autocompletion box and red cursor

Background on startup

background on startup

Button outline in debug panel

button outline in debug view

Disable and uninstall buttons

disable and uninstall buttons

Vscode feedback popup

feedback popup

Right sidebar in git diff view

git diff right sidebar

Search and replace dropdown on hover

search and replace dropdown hover

Selected tab underline in bottom tray

selected tab underline

Total settings count background and gray lines

settings gray lines and total setting count background

Sidebar file selection highlighting.

Selected (blue), hovered (dark gray) and out of focus (lighter gray)

sidebar selecting blue and grays

Welcome page quick links

welcome page quick links

@equinusocio
Copy link

equinusocio commented Apr 3, 2017

@bpasero So at the moment we can only change the statusbar color?

"workbench.experimental.colorCustomizations": {
    "statusBarBackground": "#00EECC",
    "statusBarNoFolderBackground": "#CCEE00",
    "statusBarDebuggingBackground": "#CCFFFF"
}

@bpasero
Copy link
Member

bpasero commented Apr 3, 2017

@psuedosudo thanks, maybe you could add this to #23506 where we already collect missing elements. We are well aware of some, since we have not adopted all widgets yet (e.g. like the tree/list widget that is pretty much everywhere).

@equinusocio no, the list of colors is larger. Once you open intellisense in settings you will see all:

image

@equinusocio
Copy link

@bpasero Ah nice work! There will be a documentation section about that API?

@bpasero
Copy link
Member

bpasero commented Apr 3, 2017

Yes, we are just wrapping up for the March release and plan to document theming soon. We still expect many changes to the theming API though (color keys) during April.

@equinusocio
Copy link

Oks! Thank you!

@ghost
Copy link

ghost commented Apr 3, 2017

I'm very excited about this. Are we going to be able to change the text color/format of tabs via extensions?

@equinusocio
Copy link

equinusocio commented Apr 3, 2017

@bpasero How we can define settings inside the extension? there is a place to put the colors settings? I have a textmate theme, not a json schema

@pouyakary
Copy link
Contributor

pouyakary commented Apr 5, 2017

Thanks a lot for the new update, We all wanted for this so much ❤️

One thing: As I mentioned in #21938 it would be really really cool if the activity bar could be themed light. And the problem still exists because the icons remain white:

screen shot 2017-04-05 at 11 36 23 pm

@flying-sheep
Copy link

flying-sheep commented Apr 6, 2017

for themeable icons, i suggest to adapt KDE’s approach

(and please no slight modification of it, it would be amazing if something in the software would would be actually compatible for once)

@aeschli
Copy link
Contributor

aeschli commented Apr 6, 2017

@flying-sheep Thanks for the link, didn't know that trick!

@flying-sheep
Copy link

idk if it’s a trick, but the idea is of course to replace the <style id="current-color-scheme"> with the right color definitions, see here

@pouyakary
Copy link
Contributor

@flying-sheep what a nice system!

@kieferrm kieferrm mentioned this issue Apr 6, 2017
15 tasks
@d-akara
Copy link

d-akara commented Apr 6, 2017

Are the plans to be able to customize the search results view?
I would very much like to customize coloring of file names, folders, result highlighting etc.

@patrik-martinko
Copy link

It would be nice to change:

  • the color and transparency of scrollbars
  • the color of titlebar on Windows

@bpasero
Copy link
Member

bpasero commented May 5, 2017

Support for theming the workbench has landed for April release (1.12.x) and is documented in our release notes: https://code.visualstudio.com/updates/v1_12#_workbench-theming

We close this issue and reference other related issues that were mentioned in discussions in this issue as follow up:

We still plan to add more components that are themable as we see fit and requests for.

@bpasero bpasero closed this as completed May 5, 2017
@microsoft microsoft locked and limited conversation to collaborators May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming themes Color theme issues
Projects
None yet
Development

No branches or pull requests