Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I put the extensionsGallery on my vscode fork? #31168

Open
evandrocoan opened this issue Jul 21, 2017 · 8 comments

Comments

Projects
None yet
@evandrocoan
Copy link

commented Jul 21, 2017

By default the https://github.com/Microsoft/vscode does not come with key:

"extensionsGallery": {
    "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
    "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
    "itemUrl": "https://marketplace.visualstudio.com/items"
}

on its https://github.com/Microsoft/vscode/blob/master/product.json file. That entry is required to install extensions from the marketplace as showed on:

  1. https://stackoverflow.com/questions/37143536/no-extensions-found-when-running-visual-studio-code-from-source

Also there is this commits, where their developer putted the key:

  1. b00945f
  2. f1d0c1d

But sequentially removed it justifying:

Revert inadvertant change to product.json

Why they are removing it? Seems they are using it while developing, as we may see he let slip the line to the upper stream. Can I put it on my fork? Or I can only use it locally as they seem to be doing?


Related issues:

  1. #60 Command "Extensions: Install Extension" missing when running vscode from source
  2. #2647 Command "Extensions: Install Extension" missing when running vscode from source
  3. #28253 Can't see extensions or load via command line
  4. #23831 How do I enable extensions in the extensions dir in OSS Dev mode
  5. microsoft/vscode-wiki#30 Add marketplace extension installation details
@joaomoreno

This comment has been minimized.

Copy link
Member

commented Jul 21, 2017

@MattSturgeon

This comment has been minimized.

Copy link

commented Jul 24, 2017

Since b00945f was committed under the MIT license, I would argue that you can redistribute any changes from it under a MIT compatible license.

While you cannot copy from the product.json included in the proprietary VS Code product, I would maintain that the following text has been released under MIT and therefore can be redistributed within your fork.

"extensionsGallery": {
    "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
    "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
    "itemUrl": "https://marketplace.visualstudio.com/items"
}

Being new to the project and conscious of Free Software licenses, I have never downloaded the propitiatory product, agreed to the license nor read any of the propitiatory code. My only knowledge of the above code comes through b00945f and this issue.

I am not a lawyer and this is not legal advice.

@egamma egamma added the *question label Nov 3, 2017

@kenijo

This comment has been minimized.

Copy link

commented Dec 16, 2017

A question on the cacheURL: https://vscode.blob.core.windows.net/gallery/index

It looks like it hasn't been updated since March 2017. The most recent "lastUpdated" date is 2017-03.
It there anyway to get this fixed or to get working URL?

@dtinth

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

Based on this comment, the answer is yes?

@chris-kahn

This comment has been minimized.

Copy link

commented Sep 2, 2018

Even if it wasn't licensed, the code in question is so tiny and generic (it's literally a few labels and web addresses) that I would question whether it's even copyrightable in the first place.

@jens1o

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2018

@chrisdias any legal update?

@ivanslf

This comment has been minimized.

Copy link

commented May 15, 2019

Acknowledging some public URLs and copying them into the settings file of your own product isn't a copyright infringement at all.

@nhooyr

This comment has been minimized.

Copy link

commented Jun 4, 2019

@ivanslf its not just about copying the lines, the terms of use for the vs code marketplace state that it can only be used with visual studio products. It's not clear whether that includes forks.

tagattie added a commit to tagattie/FreeBSD-VSCode that referenced this issue Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.