New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must tab through deleted tab stops in snippets #31619

Closed
Nais777 opened this Issue Jul 28, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Nais777

Nais777 commented Jul 28, 2017

  • VSCode Version: 1.14.2
  • OS Version: OSX 10.12.5

Using the following PHP snippet:

"function …": {
	"prefix": "fun",
	"body": [
		"${1:public }function ${2:FunctionName}(${3:${4:${5:Type} }$${6:var}${7: = ${8:null}}})",
		"{",
		"\t${0:# code...}",
		"}"
	],
	"description": "Function"
},

Which generates:

public function FunctionName(Type $var = null)
{
    # code...
}

If I don't want any function arguements and I delete the code inbetween ( and ) that is generated from the snippet, I have to press tab 6 times after entering tabstop 3 to get to tabstop 0.

It would be ideal if the snippet controller and session were able to understand that tab stop 3 was deleted so the nested tab stops would then be ignored.

@yangshuairocks

This comment has been minimized.

Show comment
Hide comment
@yangshuairocks

yangshuairocks Sep 3, 2018

Any updates on this issue?

yangshuairocks commented Sep 3, 2018

Any updates on this issue?

@jrieken jrieken added this to the September 2018 milestone Sep 12, 2018

@jrieken

This comment has been minimized.

Show comment
Hide comment
@jrieken

jrieken Sep 12, 2018

Member

Yes. This month is issue grooming month and that also means we look at and fix old issues. Such as this one ;-)

Member

jrieken commented Sep 12, 2018

Yes. This month is issue grooming month and that also means we look at and fix old issues. Such as this one ;-)

@jrieken jrieken closed this in 8b04cae Sep 12, 2018

@yangshuairocks

This comment has been minimized.

Show comment
Hide comment
@yangshuairocks

yangshuairocks Sep 12, 2018

Thanks for the hard work :)

yangshuairocks commented Sep 12, 2018

Thanks for the hard work :)

@mjbvz mjbvz added the verified label Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment