New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module '/home/travis/build/obrejla/vscode-jsthis/out/test' #3216

Closed
obrejla opened this Issue Feb 21, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@obrejla

obrejla commented Feb 21, 2016

Hi,

I have a problem running my extension code on Travis. The problem is, that my extension is NOT TypeScript project, so:

  1. - npm run vscode:prepublish section in .travis.ymlis not needed (when I have it there, it prints an error that typescript can not be found) and
  2. because my code is not "prepublished", then no "out" dir is created, but
  3. vscode/bin/test, which is called by a "test" script, sets current working dir to: path.join(process.cwd(), 'out', 'test') when my test dir is NOT set manually.

So it's a bit more complicated and solutions could be:

  1. describe it somewhere, how exactly should configuration for travis and plain javascript project look like, that one must define env var in .travis.yml - - CODE_TESTS_PATH="$TRAVIS_BUILD_DIR/test" (write differencies to web)
  2. detect whether user uses prepublish, and if so, then add an "out" dir to path

Or maybe I'm missing something :))

Thanks!

@bpasero bpasero added the bug label Feb 29, 2016

@bpasero bpasero added this to the March 2016 milestone Feb 29, 2016

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Mar 1, 2016

Member

Good catch, I pushed vscode@0.11.4 to address this.

Member

bpasero commented Mar 1, 2016

Good catch, I pushed vscode@0.11.4 to address this.

@bpasero bpasero closed this Mar 1, 2016

@bpasero bpasero assigned alexandrudima and unassigned bpasero Mar 13, 2016

@alexandrudima

This comment has been minimized.

Show comment
Hide comment
@alexandrudima

alexandrudima Mar 21, 2016

Member

@bpasero Not sure what I should verify?

Member

alexandrudima commented Mar 21, 2016

@bpasero Not sure what I should verify?

@bpasero

This comment has been minimized.

Show comment
Hide comment
@bpasero

bpasero Mar 21, 2016

Member

Should be ok and verified by @obrejla

Member

bpasero commented Mar 21, 2016

Should be ok and verified by @obrejla

@bpasero bpasero added the verified label Mar 21, 2016

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.