New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal fails to load PowerShell on macOS #33022

Closed
weinand opened this Issue Aug 23, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@weinand
Member

weinand commented Aug 23, 2017

  • VSCode Version: stable or insiders
  • OS Version: macOS 10.12.6 (16G29)

Steps to Reproduce:

  1. make sure to have PowerShell on macOS (I use version v6.0.0-beta.5)
  2. add setting: "terminal.integrated.shell.osx": "/usr/local/bin/powershell",
  3. try to create a new Integrated Terminal

Observe: for a brief moment this error appears and then the terminal closes:

2017-08-23_12-15-29

I had to record a screencast in order to be able to see the error message.
After that it became clear that the culprit is the default argument '-l' being passed to PowerShell.
With this setting "terminal.integrated.shellArgs.osx": [] PowerShell starts up fine.

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Aug 30, 2017

Member

This is as designed, I'd rather not get in the business of conditionally ignoring terminal.integrated.shellArgs.osx or giving it a special value sometimes. Given that Powershell is now cross platform, maybe we can add a shell switcher like on Windows to help alleviate the problem.

Member

Tyriar commented Aug 30, 2017

This is as designed, I'd rather not get in the business of conditionally ignoring terminal.integrated.shellArgs.osx or giving it a special value sometimes. Given that Powershell is now cross platform, maybe we can add a shell switcher like on Windows to help alleviate the problem.

@Tyriar Tyriar closed this Aug 30, 2017

@Tyriar Tyriar added the as-designed label Aug 30, 2017

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Aug 30, 2017

Member

Given that Powershell is now cross platform, why do we then pass an argument '-l' to PowerShell that is not cross platform?

Member

weinand commented Aug 30, 2017

Given that Powershell is now cross platform, why do we then pass an argument '-l' to PowerShell that is not cross platform?

@Tyriar

This comment has been minimized.

Show comment
Hide comment
@Tyriar

Tyriar Aug 30, 2017

Member

Because the default for terminal.integrated.shellArgs.osx is ["-l"] as Mac's run shells as login shells by default. I might add some documentation around using PowerShell on Mac to help this.

Member

Tyriar commented Aug 30, 2017

Because the default for terminal.integrated.shellArgs.osx is ["-l"] as Mac's run shells as login shells by default. I might add some documentation around using PowerShell on Mac to help this.

@Tyriar Tyriar reopened this Aug 30, 2017

@Tyriar Tyriar removed the as-designed label Aug 30, 2017

@Tyriar Tyriar added this to the September 2017 milestone Aug 30, 2017

@Tyriar Tyriar modified the milestones: September 2017, October 2017 Sep 23, 2017

@chrmarti chrmarti removed the insiders label Sep 27, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 14, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.