New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not work when modify editor.fontSize to default #33537

Closed
cuiyongjian opened this Issue Aug 30, 2017 · 6 comments

Comments

Projects
None yet
5 participants
@cuiyongjian

cuiyongjian commented Aug 30, 2017

  • VSCode Version: 1.15.1
  • OS Version: Mac OS sierra 10.12.3

Steps to Reproduce:

  1. open the preference setting with cmd+,
  2. change the editor.fontSize to 14 (default is 12), you can see the editor fontsize has change
  3. Then i change the editor.fontSize to the original 12, but you can see it keep 14
  4. Only when i close the setting page , and reopen it , the font-size will take effect

Reproduces without extensions: Yes

@alexandrudima

This comment has been minimized.

Member

alexandrudima commented Aug 31, 2017

I have just tried it out and cannot reproduce.

@sandy081

This comment has been minimized.

Member

sandy081 commented Aug 31, 2017

I cannot reproduce neither in stable nor insiders.

@cuiyongjian Can you please try in insiders https://code.visualstudio.com/insiders and check

@alexandrudima

This comment has been minimized.

Member

alexandrudima commented Aug 31, 2017

Perhaps there is a missing save, or we only save on close ... ?

@cuiyongjian

This comment has been minimized.

cuiyongjian commented Sep 2, 2017

@alexandrudima @sandy081

Tody I have tryed the insider version, It seems to have fixed the problem. Thank you!

And now I paste the picture of my symptoms with stable version 1.15:

  1. below is the pic when i set nothing (it is really 12px):
    image

  2. this is the pic when i set font-size to 14:
    image
    you can see it changed to 14px

  3. below is the pic when i reset to 12
    image

it keep 14px.


@chrmarti chrmarti removed the new release label Sep 7, 2017

@ant31

This comment has been minimized.

ant31 commented Sep 22, 2017

Have you check that you don't have fontSize configured in both 'workspace setting' and 'user setting'

@cuiyongjian

This comment has been minimized.

cuiyongjian commented Sep 23, 2017

Today, i retry it with stable version 1.15.1. It is worked. it is really Strange 奇怪的.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.