New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for `debuggers.initialConfigurations` command contribution #33794

Closed
weinand opened this Issue Sep 4, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@weinand
Member

weinand commented Sep 4, 2017

With the introduction of the provideDebugConfigurations method on type DebugConfigurationProvider, it is no longer necessary to contribute a command for the debuggers.initialConfigurations contribution point. Therefore we are deprecating the ability to specify a command ID in this milestone and plan to drop it in October (but we will continue the support for contributing a JSON object literal).

@rkeithhill

This comment has been minimized.

Show comment
Hide comment
@rkeithhill

rkeithhill Oct 21, 2017

Just to be clear, debuggers.initialConfigurations will continue to be supported in package.json right? We still have this section in our package.json and it appears that information is still being processed by VS Code Insider 1.18. Our DebugConfigurationProvider.provideDebugConfigurations method just returns an empty array atm. Yet, when you configure a blank folder for PowerShell debug support, all of the configurations defined in package.json are listed. Is this working as expected? Or should we move those defs from package.json into this method? Seems a bit weird to return a big object array literal but that is probably what we would do.

rkeithhill commented Oct 21, 2017

Just to be clear, debuggers.initialConfigurations will continue to be supported in package.json right? We still have this section in our package.json and it appears that information is still being processed by VS Code Insider 1.18. Our DebugConfigurationProvider.provideDebugConfigurations method just returns an empty array atm. Yet, when you configure a blank folder for PowerShell debug support, all of the configurations defined in package.json are listed. Is this working as expected? Or should we move those defs from package.json into this method? Seems a bit weird to return a big object array literal but that is probably what we would do.

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Oct 23, 2017

Contributor

debuggers.initialConfigurations as an json object will continue to be supported in package.json

Contributor

isidorn commented Oct 23, 2017

debuggers.initialConfigurations as an json object will continue to be supported in package.json

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Oct 23, 2017

Member

Since debuggers.initialConfigurations is still supported, please don't implement DebugConfigurationProvider.provideDebugConfigurations (instead of returning an empty array).
All DebugConfigurationProvider methods are optional and you do not have to implement any of them.

Member

weinand commented Oct 23, 2017

Since debuggers.initialConfigurations is still supported, please don't implement DebugConfigurationProvider.provideDebugConfigurations (instead of returning an empty array).
All DebugConfigurationProvider methods are optional and you do not have to implement any of them.

rkeithhill added a commit to PowerShell/vscode-powershell that referenced this issue Oct 23, 2017

@rkeithhill

This comment has been minimized.

Show comment
Hide comment
@rkeithhill

rkeithhill Oct 23, 2017

Got it. Fixed in pending PR.

BTW in the resolveDebugConfiguration method, we have a particular config (attach) that will not work when running in PS Core (vs Windows PowerShell). When I detect that, can I just return out of this method? That seems to work. Or is it better to return undefined? Here's the impl.

rkeithhill commented Oct 23, 2017

Got it. Fixed in pending PR.

BTW in the resolveDebugConfiguration method, we have a particular config (attach) that will not work when running in PS Core (vs Windows PowerShell). When I detect that, can I just return out of this method? That seems to work. Or is it better to return undefined? Here's the impl.

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Oct 23, 2017

Contributor

Yeah in that case just return undefined for the config and vscode will hande things correctly

Contributor

isidorn commented Oct 23, 2017

Yeah in that case just return undefined for the config and vscode will hande things correctly

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Oct 23, 2017

Member

You can even show an error message in this case (see example from node-debug: https://github.com/Microsoft/vscode-node-debug/blob/fffc26014b7bf06a3ba061ff46adc69cff58158a/src/node/extension/configurationProvider.ts#L41)

I've tried to improve the documentation around this:

* Returning the value 'undefined' prevents the debug session from starting.

Member

weinand commented Oct 23, 2017

You can even show an error message in this case (see example from node-debug: https://github.com/Microsoft/vscode-node-debug/blob/fffc26014b7bf06a3ba061ff46adc69cff58158a/src/node/extension/configurationProvider.ts#L41)

I've tried to improve the documentation around this:

* Returning the value 'undefined' prevents the debug session from starting.

rkeithhill added a commit to rkeithhill/vscode-powershell that referenced this issue Oct 23, 2017

daviwil added a commit to PowerShell/vscode-powershell that referenced this issue Oct 23, 2017

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn
Contributor

isidorn commented Oct 25, 2017

@pieandcakes

This comment has been minimized.

Show comment
Hide comment
@pieandcakes

pieandcakes Oct 25, 2017

Contributor

@isidorn This will be part of Stable 1.18 ? or does it already exist in 1.17?

@WardenGnaw

Contributor

pieandcakes commented Oct 25, 2017

@isidorn This will be part of Stable 1.18 ? or does it already exist in 1.17?

@WardenGnaw

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Oct 26, 2017

Contributor

@pieandcakes we will remove the support for this in 1.18. DebugConfigurationProviders already exist in 1.17.

You can try it all out in insiders

Contributor

isidorn commented Oct 26, 2017

@pieandcakes we will remove the support for this in 1.18. DebugConfigurationProviders already exist in 1.17.

You can try it all out in insiders

daviwil added a commit to PowerShell/vscode-powershell that referenced this issue Oct 26, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.