New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting debug.logToDebugConsole command #34700

Closed
isidorn opened this Issue Sep 20, 2017 · 12 comments

Comments

Projects
None yet
3 participants
@isidorn
Contributor

isidorn commented Sep 20, 2017

Currently we support a 'debug.logToDebugConsole' command.

KeybindingsRegistry.registerCommandAndKeybindingRule({

Instead we should introduce API and deprecate this command.

@isidorn isidorn added this to the October 2017 milestone Sep 20, 2017

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Sep 29, 2017

Contributor

Removing this only makes sense in november. First in october we have to create a solution for this using the debug api.

Contributor

isidorn commented Sep 29, 2017

Removing this only makes sense in november. First in october we have to create a solution for this using the debug api.

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Sep 29, 2017

Member

I will do this on October 23 ;-)

Member

weinand commented Sep 29, 2017

I will do this on October 23 ;-)

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Sep 29, 2017

Contributor

I can also look into this, just wrote down a note for myself :)

Contributor

isidorn commented Sep 29, 2017

I can also look into this, just wrote down a note for myself :)

@isidorn isidorn modified the milestones: October 2017, November 2017 Oct 2, 2017

@egamma egamma referenced this issue Oct 9, 2017

Closed

Iteration Plan for October 2017 #35875

38 of 40 tasks complete
@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Oct 23, 2017

Member

I've created an API request for this.

Member

weinand commented Oct 23, 2017

I've created an API request for this.

@weinand weinand removed their assignment Oct 23, 2017

@weinand weinand modified the milestones: November 2017, Backlog Nov 7, 2017

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Nov 7, 2017

Member

Since the API will be proposed in November, we cannot delete this in November.

Member

weinand commented Nov 7, 2017

Since the API will be proposed in November, we cannot delete this in November.

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Nov 7, 2017

Contributor

@weinand should I create and assign this to the December milestone?

Contributor

isidorn commented Nov 7, 2017

@weinand should I create and assign this to the December milestone?

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Nov 7, 2017

Member

Let's wait until we know more about Xmas...

Member

weinand commented Nov 7, 2017

Let's wait until we know more about Xmas...

@Alphapage

This comment has been minimized.

Show comment
Hide comment
@Alphapage

Alphapage Dec 5, 2017

It seems to only support string message, but I need to display an object to be able to navigate properties as we do when using "Debugger evaluation" in vscode.
I didn't find a way to do this from an extension. Is it possible ?

Alphapage commented Dec 5, 2017

It seems to only support string message, but I need to display an object to be able to navigate properties as we do when using "Debugger evaluation" in vscode.
I didn't find a way to do this from an extension. Is it possible ?

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn Dec 5, 2017

Contributor

@Alphapage That is only possible from a debug adapter. As an example, you can checkout node debug 2 and find when he sends the variableReference in the OutputEvent if that is what you are looking for.

Contributor

isidorn commented Dec 5, 2017

@Alphapage That is only possible from a debug adapter. As an example, you can checkout node debug 2 and find when he sends the variableReference in the OutputEvent if that is what you are looking for.

@weinand

This comment has been minimized.

Show comment
Hide comment
@weinand

weinand Dec 5, 2017

Member

@Alphapage expandable objects need an active debug session behind them (so that the UI can request more data on expand). When outputting an object from an extension, then there is not necessarily a debug session active.
So constraining the API to string is intentional.

Member

weinand commented Dec 5, 2017

@Alphapage expandable objects need an active debug session behind them (so that the UI can request more data on expand). When outputting an object from an extension, then there is not necessarily a debug session active.
So constraining the API to string is intentional.

@Alphapage

This comment has been minimized.

Show comment
Hide comment
@Alphapage

Alphapage Dec 5, 2017

As you told, I think I was going to the wrong direction: I just need to add an UI panel to the extension to be able to navigate the object.
Thank you very much.

Alphapage commented Dec 5, 2017

As you told, I think I was going to the wrong direction: I just need to add an UI panel to the extension to be able to navigate the object.
Thank you very much.

@isidorn

This comment has been minimized.

Show comment
Hide comment
@isidorn

isidorn May 11, 2018

Contributor

This was done in January / February it seems

Contributor

isidorn commented May 11, 2018

This was done in January / February it seems

@isidorn isidorn closed this May 11, 2018

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.