Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke Test: Don't get cross file intellisense in JS #3509

Closed
alexdima opened this issue Feb 26, 2016 · 4 comments
Closed

Smoke Test: Don't get cross file intellisense in JS #3509

alexdima opened this issue Feb 26, 2016 · 4 comments
Assignees
Milestone

Comments

@alexdima
Copy link
Member

@alexdima alexdima commented Feb 26, 2016

  • in the smoke test repo, add a new file bar.js:
exports.foo = 3;
  • in app.js add the following:
var bar = require('./bar');
bar.

No completions on bar

@alexdima alexdima added this to the Feb 2016 milestone Feb 26, 2016
@alexdima

This comment has been minimized.

Copy link
Member Author

@alexdima alexdima commented Feb 26, 2016

image

@alexdima alexdima added the bug label Feb 26, 2016
@egamma

This comment has been minimized.

Copy link
Member

@egamma egamma commented Feb 29, 2016

The smoketest repo doesn't have a jsconfig.json. When I add the following jsconfig.json

{
    "compilerOptions": {
        "module": "commonjs"
    }
}

Then this works. However, this should also be the default when there is no jsconfig.json.

@joaomoreno

This comment has been minimized.

Copy link
Member

@joaomoreno joaomoreno commented Feb 29, 2016

Documentation

@egamma

This comment has been minimized.

Copy link
Member

@egamma egamma commented Mar 15, 2016

Upstream fix merged into our code.

@egamma egamma closed this Mar 15, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.