Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited native window tabs functionality in macOS high sierra #35361

Closed
ddotlic opened this issue Sep 29, 2017 · 99 comments
Closed

Limited native window tabs functionality in macOS high sierra #35361

ddotlic opened this issue Sep 29, 2017 · 99 comments

Comments

@ddotlic
Copy link
Contributor

@ddotlic ddotlic commented Sep 29, 2017

  • VSCode Version: Code - Insiders 1.17.0-insider (f7962f0, 2017-09-20T05:10:59.524Z)
  • OS Version: Darwin x64 17.0.0
  • Extensions: (unimportant, see below)

Steps to Reproduce:

  1. Try to use "window.nativeTabs": true option, notice the squiggles and message says Unknown configuration setting
  2. If you remove the setting, opening a new window does create a new window
  3. If you put the setting back, it is respected, but creating a new window creates (visually) empty native tab bar (previously it showed two tabs, as expected); clicking on the tab creates a new window, as if the whole tab bar is in fact the newly added (looking at 1.17 release notes) "+" button to add a new window/tab
  4. Switching windows works, my custom shortcuts are respected etc. all is well, except tabs display

One more thing 😉 bizarrely my insider hasn't been updates since 20th of September (never seen insider go for 10 days without update). Downloading insider from Code's site also yields 20th of Sep version.

Reproduces without extensions: YES (as expected)

@vscodebot vscodebot bot added the workbench label Sep 29, 2017
@sandy081 sandy081 assigned bpasero and unassigned sandy081 Sep 29, 2017
@bpasero
Copy link
Member

@bpasero bpasero commented Sep 29, 2017

@ddotlic but you are seeing the native tab bar to the top of the window?

image

@bpasero bpasero added this to the Backlog milestone Sep 29, 2017
bpasero added a commit that referenced this issue Sep 29, 2017
@ddotlic
Copy link
Contributor Author

@ddotlic ddotlic commented Sep 29, 2017

Sorry, I'll post a screenshot now, it might be clearer (or not, you'll see):
screen shot 2017-09-29 at 10 25 35

The whole "tab" area behaves like a "+" button in your screenshot.

@ddotlic
Copy link
Contributor Author

@ddotlic ddotlic commented Sep 29, 2017

Needless to say, this worked fine yesterday (before I installed High Sierra update), this is a MacBook Pro 2015, always up to date so I expect no issues with drivers etc.

If I can do something else to help (provide more info by running with particular command line switches) please do not hesitate to ask.

@bpasero bpasero changed the title Native tabs seem broken on High Sierra, using latest (yet stale) insider Limited native window tabs functionality in macOS high sierra Sep 29, 2017
@bpasero
Copy link
Member

@bpasero bpasero commented Sep 29, 2017

Unfortunately this looks like an issue in Elecron, I filed: electron/electron#10657

For now the functionality seems limited at best. I think all that is going wrong is the rendering of native tabs, but otherwise the tabs are there.

@ddotlic
Copy link
Contributor Author

@ddotlic ddotlic commented Sep 29, 2017

Thanks for the info. We'll likely either see more people confirming the same when 1.17 comes out, or not 😄 in which case it'll be some fluke on my machine that I'll need to figure out somehow.

@bpasero Do you have any idea if it's normal for insider to not be updated for the last 10 days??

@bpasero
Copy link
Member

@bpasero bpasero commented Sep 29, 2017

@ddotlic yes, our signing service currently is not active.

@giricgoyal
Copy link

@giricgoyal giricgoyal commented Oct 1, 2017

Having this issue with VS Code v 1.16.1 and Mac OS High Sierra.

"window.nativeTabs" option is not available in settings anymore.
View > Show Tab Bar: Shows the tab bar but Cmd + Shift + N does not open new window in new tab.

@primalmotion
Copy link

@primalmotion primalmotion commented Oct 5, 2017

I confirm I have the exact same issue with VSCode 1.17.0. It was working with the previous version on High Sierra (even if the window.nativeTabs was not officially supported)

@williamli
Copy link

@williamli williamli commented Oct 6, 2017

Just upgraded to v1.17.0 on High Sierra and I too experience this problem when "window.nativeTabs": true is enabled. Got a massive + new tab button (with no label on it) and not seeing any tabs until I go to "Show All Tabs"

@primalmotion
Copy link

@primalmotion primalmotion commented Oct 6, 2017

I sent a fix here electron/electron#10696 (review)

You can work around the issue by building Electron from my PR, then replace it from the VSCode.app/Contents/MacOS. A bit complicated, but I can't live without native tabs support :)

@Hum4n01d
Copy link

@Hum4n01d Hum4n01d commented Oct 15, 2017

Same issue here

@hemedani
Copy link

@hemedani hemedani commented Oct 26, 2017

I have the same issue

@bpasero
Copy link
Member

@bpasero bpasero commented Jun 26, 2018

Let's try how it goes with systemPreferences.setUserDefault(), I pushed this for todays insider build.

@zhuowei
Copy link
Contributor

@zhuowei zhuowei commented Jun 26, 2018

@bpasero Yeah, it will only affect our application. Anyways, my concern was that setUserDefault is persisted, so if a user turns on native tabs, the preference is set, and after the user disables native tabs, the preference is still set. registerDefaults is in memory only, so that may be a better choice. This should work though.

@bpasero
Copy link
Member

@bpasero bpasero commented Jun 26, 2018

@zhuowei that is a good point, however I would at one point maybe even turn this on for everyone once we have a better understanding what the impact is

@ddotlic
Copy link
Contributor Author

@ddotlic ddotlic commented Jun 26, 2018

@bpasero The fix works like a charm for me (latest insider from couple hours ago, latest possible macOS).

Thanks for not giving up on this!

@bpasero bpasero closed this Jun 26, 2018
@chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jun 28, 2018

Trying to verify this (as per our end-of-milestone ritual), but don't see a difference between the default and native tabs enabled.

With native tabs enabled:
image

@ddotlic
Copy link
Contributor Author

@ddotlic ddotlic commented Jun 28, 2018

@chrmarti I'm not sure but it seems like you're looking at document tabs? These don't change either way.

The tabs this relates to are the ones for the workspace, you need to have multiple workspaces open to be able to see them.

@jeffaxial
Copy link

@jeffaxial jeffaxial commented Jun 28, 2018

@chrmarti Open a new window. The native tabs aren't for file tabs, they are for window/workspace tabs. If working correctly, when you open a new window, you should see 2 window tabs. If not working correctly (as it has been for months now), you will just see a blank gray bar at the top.

If you've used tabs in Finder, it's the same idea.

@fmunteanu
Copy link

@fmunteanu fmunteanu commented Jun 28, 2018

@bpasero when is the insider build will make it to stable release?

@chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jun 28, 2018

Thanks! Still no tabs though, I get additional windows. I'm on:

  • VS Code version: Code - Insiders 1.25.0-insider (07d89ab, 2018-06-28T05:11:09.274Z)
  • OS version: Darwin x64 17.6.0
@jeffaxial
Copy link

@jeffaxial jeffaxial commented Jun 28, 2018

@chrmarti Make sure that "window.nativeTabs" is set to true in your user settings.

With that set to true, you shouldn't get multiple windows even if the native tabs fix wasn't present.

@ddotlic
Copy link
Contributor Author

@ddotlic ddotlic commented Jun 28, 2018

@chrmarti You are holding it wrong 😉 You cannot verify whether this works or not unless you have triggered the appearance of tabs per workspace. This is another row of tabs above the document tabs.

@chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jun 28, 2018

Got some help from @bpasero. Everything works now, thanks! Marking verified.

@chrmarti chrmarti closed this Jun 28, 2018
@fmunteanu
Copy link

@fmunteanu fmunteanu commented Jun 28, 2018

@chrmarti when do we have this fix pushed into stable release?

@chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jun 28, 2018

@fmunteanu With 1.25 some time next week.

@sebastianreloaded
Copy link

@sebastianreloaded sebastianreloaded commented Jul 6, 2018

for me it didn't work at first but after disabling nativeTabs and reenabling them through the new settings editor worked.

@pi0
Copy link

@pi0 pi0 commented Jul 6, 2018

I can confirm it is working like a charm now :)

MacOS: 10.13.4
VSCode: 1.25.0-insider

image

@deyhle
Copy link

@deyhle deyhle commented Jul 6, 2018

Wait, so the native tabs are replacing the file tabs? I was under the impression that native tabs are (finally) a way to properly switch between multiple project windows, and that we have the file tabs rendered in VS Code below those for each project. So with native tabs we're also losing the grid layout editor functionality?

@chabou-san
Copy link

@chabou-san chabou-san commented Jul 6, 2018

@deyhle They are not replacing the file tabs, see my screenshots below :

screen shot 2018-07-06 at 10 04 43

It's behaving exactly as you'd have them to. I could have show you the grid layout functionality too, it's just that I didn't in my screenshot. But I can confirm it's also working. ;)

@fmunteanu
Copy link

@fmunteanu fmunteanu commented Jul 6, 2018

@chrmarti I don't see the feature listed in 1.25 (stable just released), can you please confirm it is implemented? Thanks!

@scottohara
Copy link

@scottohara scottohara commented Jul 7, 2018

@fmunteanu As it's not a new feature (but rather a fix to an existing feature that broke in High Sierra), you'll find it under the "Notable Changes" and "Thank You" sections of the release notes.

I can confirm that it is implemented and working in stable. 🎉

release_notes__1_25_0_and_limited_native_window_tabs_functionality_in_macos_high_sierra_ issue__35361 _microsoft_vscode

release_notes__1_25_0_ _confluence-open-api-connect

@RoarkeRandall
Copy link

@RoarkeRandall RoarkeRandall commented Jul 7, 2018

@pho3nixf1re
Copy link

@pho3nixf1re pho3nixf1re commented Jul 7, 2018

@wunc wunc mentioned this issue Jul 9, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.